MetaProvider merging is too simple about dist-zilla HOT 9 CLOSED

Would Hash::MultiValue be useful here?

from dist-zilla.

No, it really needs a deep merge.

IIRC, the spec requires array ref anywhere lists are possible, so it should
be safe to add lists.

Possibly, dzils metadata plugin model is wrong and each should get an
opportunity to modify the full hash instead of trying to naively aggregate.

Otherwise, list adding is going to lose sort, which sort of sucks.

David
On Mar 17, 2013 5:28 PM, "Karen Etheridge" [email protected] wrote:

Would Hash::MultiValue be useful here?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/151#issuecomment-15031289
.

from dist-zilla.

I suggest Hash::Merge.

It still will lose sorting of array merges, but, oh, well, I'd rather have half a solution than none.

from dist-zilla.

I'd suggest we come up with a CPAN::Meta::Merge.

Instead of a one-size-fits-all approach, a more tailored solution might give better results. This issue comes up in pretty much any place that generates meta files, a generic solution may be worth it.

from dist-zilla.

Well volunteered? :-)

from dist-zilla.

Well volunteered? :-)

Sure

Feedback welcome.

from dist-zilla.

Great start. I've opened up tickets there for my feedback.

from dist-zilla.

The meta-merging code now exists, so presumably what remains is for someone to make DZ use it.

from dist-zilla.

Yes, this is #334 :)

from dist-zilla.