Git Product home page Git Product logo

Comments (2)

mlesnick avatar mlesnick commented on May 22, 2024

Original comment by Matthew Wright (GitHub: mlwright84):


Thanks for pointing this out.

I assume that the two lines you have selected in the screenshots above are exactly vertical -- i.e., the angle box (not shown) reads 90.000 degrees.

We could make the lower blue dot snap to the bottom-left corner of the box when the top dot is in the top-left corner (or the bottom-right corner), with the blue line extending all the way to the corner as well. This doesn't seem too hard to implement (but it might end up being harder than it seems), and as you say, it might be awkward for the user.

Making the blue line extend all the way to the corner without moving the lower blue dot would be harder to implement, because it would involve detaching the endpoints of the line from the blue dots. Currently, the endpoints of the line are always at the center of the blue dots. Changing this would involve modifying the C++ classes for the lines and dots, which is tricky -- these clickable objects respond to each other, and modifying one can produce unintended consequences for the others. Certainly it's possible to implement this solution, but it will take some work.

Still, even if we modify what happens for vertical lines, the user will always be able to approximate the behavior shown in the first screenshot above by selecting a nearly vertical line, such as a line at angle of 89.999 degrees, that appears vertical on the screen, and whose lower endpoint is in the middle of the left side of the box. However, such behavior for a non-vertical line is consistent with our description in the paper, while what can happen now for vertical lines is not consistent with the paper.

from rivet.

mlesnick avatar mlesnick commented on May 22, 2024

Original comment by M L (GitHub: mlesnick):


One solution in between the two proposed extremes, is to keep the interactivity of the lower blue dot the same (so that it never skips down to the bottom left corner), but when the blue line becomes horizontal, have it extend all the way down to the corner, and have it plot the barcode taking \gamma(0)=0, so that as we slide the blue dot up and down the y-axis, the barcode doesn't change.

from rivet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.