When listing plugins, Path should not be needed about risu HOT 8 CLOSED

@larsks Want to take this one?

from risu.

Sure!

from risu.

So, the problem here is that without --live, we assume that the first argument is a filesystem snapshot. What if we were to change the behavior so that by default citellus would run in live mode, and an explicit snapshot argument would be required for snapshot mode? So on a live system you would run:

citellus

And for sos reports you would run:

citellus --snapshot /cases/123456/...

This would allow --list-plugins to work without introducing some convoluted logic to use different plugin path semantics with --list-plugins than we use for actual citellus runs.

from risu.

Wouldn't running the check for --list-plugins be executed earlier allow to keep actual behaviour?

For example:
change the actual else at line 304:
for:

elif not options.list_plugins:
# This will execute if options.list_plugins is set to false, hence, exitting if not Live is active

from risu.

Right, but at the moment we can only do plugin discovery in general after deciding whether we're in live mode or not. We could also do plugin discovery earlier for --list-plugins, but then we'd need it in two places, which is silly. Or we would need some sort of "if --live or --list-plugins..." then logic.

Making the snapshot path an explicit argument rather than an implicit argument would make everything nicer.

from risu.

I do use it mostly against snapshots, so having to declare it will be more typing afaik.

from risu.

@larsks @iranzo Explicit is better than Implicit. We can add argument -s/--snapshot that will not add too much typing and code will be more read-able, it will be easier and less prone to errors. Agree?

from risu.

Not requiring to modify already existing docs and integrations approach: http://review.gerrithub.io/377922

from risu.