Git Product home page Git Product logo

Comments (6)

ripienaar avatar ripienaar commented on July 17, 2024

OK, yah not entirely sure myself, have commented on the original pull hopefullyt he author can help

from graphite-graph-dsl.

ripienaar avatar ripienaar commented on July 17, 2024

Have pushed 0.0.5 that uses CGI.escape instead of URI.encode and it seems good now

from graphite-graph-dsl.

jrust avatar jrust commented on July 17, 2024

Unfortunately that led to too much being escaped. I end up with image URLs like: /render/?title%3DBilling%26vtitle%3DBilling which result in No Data images. It seems like just the value parts of the key/value pairs should be escaped. This got all my graphs working again:

url_str = url_parts.map { |pair| k,v = pair.split('='); "#{k}=#{CGI.escape(v)}" }.join("&")
properties[:placeholders].each { |k,v| url_str.gsub!("%{#{k}}", v.to_s) } if properties[:placeholders].is_a?(Hash)
url_str

from graphite-graph-dsl.

ripienaar avatar ripienaar commented on July 17, 2024

Ah yeah indeed, you would just escape the values.

Don't code before coffee :)

Will do another release soon

from graphite-graph-dsl.

ripienaar avatar ripienaar commented on July 17, 2024

OK, I did 0.0.6, lets see how that one goes :)

from graphite-graph-dsl.

jrust avatar jrust commented on July 17, 2024

Yup, worked great after bumping gdash up to the 0.0.6. Thanks.

from graphite-graph-dsl.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.