Comments (4)
Well the riot compiler should not check if you can write javascript. It just check if eventually your tag can be correctly parsed and compiled
from cli.
Yes. It should not check my js.
But accordingly to you this sample tag is correct
$ riot tags/home2.tag --check
No syntax error. Ready to compile :)
$ cat tags/home2.tag
<home>
<div <<
<span />
<script>
�01A�M��É��A���I�Å�@¶�¸ýÿÿÿH���Þ��éÎ���I�E�¾-���H�Çè����HÀt�Æ� I�Å�H� ïÿÿH�ÇL�îè¨g����{Ü���
</script>
'<home>
</home>
\'
And moreover it was properly compiled into this js
$ riot tags/home2.tag tags/home2.js
tags/home2.tag -> tags/home2.js
$ cat tags/home2.js
riot.tag2('home', '<div span></div> \'<home>', '', '', function(opts) {
�01A�M��É��A���I�Å�@¶�¸ýÿÿÿH���Þ��éÎ���I�E�¾-���H�Çè����HÀt�Æ� I�Å�H� ïÿÿH�ÇL�îè¨g��{Ü���
});
\'
Syntax checking and compilation can't behave two different ways.
It shouldn't fail in compilation after successfully checking.
It shouldn't fail in checking and successfully compile at same time.
$ riot tags/home4.tag --check
Riot Tag Syntax Error
EOF |
^^^ Last tag definition is not closed
Total error: 1 in "tags/home4.tag"
$ cat tags/home4.tag
<home>
<h2>
<script>var 1 = function()</script>
$ riot tags/home4.tag tags/home4.js
tags/home4.tag -> tags/home4.js
$ cat tags/home4.js
<home>
<h2>
riot.tag2('script', 'var 1 = function()', '', '', function(opts) {
});
from cli.
I agree, the syntax checker could be optimized. Thanks for your input
from cli.
now with the new compiler we should throw error in case of broken syntax. This issue can be closed
from cli.
Related Issues (20)
- Ubuntu watch issue HOT 3
- riot cli in webstorm not compiling typescript with let or const HOT 8
- Typescript failing due to not using d.ts files. HOT 3
- In 6.x, the babel package has been deprecated in favor of babel-cli HOT 1
- can't compile tags on Windows HOT 5
- Messages with Node v10.0.0 HOT 1
- --watch not working on Windows HOT 4
- Is this cli planned to be compatible with Riot@4? HOT 3
- Watch new files
- Failed to compile multiple riot components to a single js file HOT 4
- cli ralways eturns exitcode 0 on errors HOT 1
- Riot not found on windows 10 HOT 2
- install instructions not working in Windows 10 HOT 2
- Error when trying to watch dir of riot files HOT 1
- Version 5.1.0 breaks riot.config.js HOT 2
- Does cli support typescript syntax in `<script>` tag? HOT 5
- Error: Cannot find module 'babylon'
- Cant use CLI without declaring devDependency HOT 1
- Upgrading from v5 to v6 HOT 1
- riot -w does not show errors
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cli.