Git Product home page Git Product logo

Comments (4)

GianlucaGuarini avatar GianlucaGuarini commented on June 13, 2024

Well the riot compiler should not check if you can write javascript. It just check if eventually your tag can be correctly parsed and compiled

from cli.

tayler1 avatar tayler1 commented on June 13, 2024

Yes. It should not check my js.
But accordingly to you this sample tag is correct

$ riot tags/home2.tag --check
No syntax error. Ready to compile :)
$ cat tags/home2.tag
<home>
    <div <<
    <span />

    <script>
    �01A�M��É��A���I�Å�@¶�¸ýÿÿÿH���Þ��éÎ���I�E�¾-���H�Çè����HÀt�Æ� I�Å�H�  ïÿÿH�ÇL�îè¨g����{Ü���
    </script>
  '<home>
</home>
\'

And moreover it was properly compiled into this js

$ riot tags/home2.tag tags/home2.js
tags/home2.tag -> tags/home2.js
$ cat tags/home2.js
riot.tag2('home', '<div span></div> \'<home>', '', '', function(opts) {
    �01A�M��É��A���I�Å�@¶�¸ýÿÿÿH���Þ��éÎ���I�E�¾-���H�Çè����HÀt�Æ� I�Å�H�  ïÿÿH�ÇL�îè¨g��{Ü���
});
\'

Syntax checking and compilation can't behave two different ways.
It shouldn't fail in compilation after successfully checking.
It shouldn't fail in checking and successfully compile at same time.

$ riot tags/home4.tag --check
Riot Tag Syntax Error
EOF | 
^^^  Last tag definition is not closed
Total error: 1 in "tags/home4.tag"
$ cat tags/home4.tag
<home>
 <h2>
 <script>var 1 = function()</script>
$ riot tags/home4.tag tags/home4.js
tags/home4.tag -> tags/home4.js
$ cat tags/home4.js
<home>
 <h2>
riot.tag2('script', 'var 1 = function()', '', '', function(opts) {
});

from cli.

GianlucaGuarini avatar GianlucaGuarini commented on June 13, 2024

I agree, the syntax checker could be optimized. Thanks for your input

from cli.

GianlucaGuarini avatar GianlucaGuarini commented on June 13, 2024

now with the new compiler we should throw error in case of broken syntax. This issue can be closed

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.