Strict mode about mapperly HOT 4 CLOSED

Currently there is a diagnostic RMG012: Mapping source property not found which is emitted when a source property is not found with the severity of info. However, you can set its severity to error by adding dotnet_diagnostic.RMG012.severity = error to your editorconfig. The message of RMG012 is not optimal (it doesn't note what the target class is). Also there is no diagnostic if a property does only exist on source but not on target.

A diagnostic for unmapped source properties sounds like a good idea to implement. Feel free if you want to contribute a PR.

from mapperly.

Thanks for your answer :)

I haven't worked with source generators at all, so could you give some pointers on how you would implement such a thing?

from mapperly.

To add the target type to the message of RMG012: Look up usages of MappingSourcePropertyNotFound in Riok.Mapperly.Diagnostics.DiagnosticDescriptors, extend its message format and add the target type message argument on the callers side.

To add a new diagnostic when there is an unmapped source property add a new entry in Riok.Mapperly.Diagnostics.DiagnosticDescriptors and AnalyzerReleases.Shipped.md.
In Riok.Mapperly.Descriptors.MappingBuilder.ObjectPropertyMappingBuilderContext, track a set of source properties and remove them as they are used in a mapping (eg. in Riok.Mapperly.Descriptors.MappingBuilder.ObjectPropertyMappingBuilder.BuildMappingBody, Riok.Mapperly.Descriptors.MappingBuilder.NewInstanceObjectPropertyMappingBuilder.TryBuildConstructorMapping, Riok.Mapperly.Descriptors.MappingBuilder.NewInstanceObjectPropertyMappingBuilder.BuildInitOnlyPropertyMappings). Finally report the diagnostics as needed in Riok.Mapperly.Descriptors.MappingBuilder.ObjectPropertyMappingBuilder.BuildMappingBody (similar how RMG004 is reported).

Add tests in Riok.Mapperly.IntegrationTests and Riok.Mapperly.Tests. You can use the tests in Riok.Mapperly.Tests to debug Mapperly.

Hope this helps 😊 If you have any questions, suggestions/feedback or need further assistance, let me know.

from mapperly.

Released in Mapperly 2.3.0. Check the readme on how to use it and let me know if you have any feedback.

from mapperly.