[Linux] Crashes with segmentation fault when 'xterm' is missing about rimpy HOT 6 CLOSED

RimPy need xterm to handle downloading process

from rimpy.

So it seems, I found this out the hard way as it doesn't appear to be documented... Candidate for the "RimPy crashes" section of the FAQ?

It's also kinda ugly to segfault there instead of informing the user about the problem TBH. If I'd got a warning rather than a hard crash, I would have just installed xterm, rather than creating an issue.

from rimpy.

As there is not a 100% sure-proof and silver bullet solution to always find the system's terminal emulator, I thought I might throw out a simple and easy-to-implement solution to consider:

• Attempt to find it via xdg-terminal
• Attempt to read $TERM and $TERMINAL variables
• Simply check against a list of a the dozen or so terminals that are actually in-use. While this sounds like a bad approach (it is), it is still better than just assuming xterm is present.
• Fallback and use xterm if nothing else is found AND xterm is actually found, otherwise emit error message.

Otherwise, please consider listing xterm as a hard-dependency. I apologize if you have already, but I was unable to find it prominently listed anywhere.

from rimpy.

@ForeverZer0 I have got this list:
("x-terminal-emulator", "urxvt", "rxvt", "terminator", "Eterm", "aterm", "xterm", "gnome-terminal", "roxterm", "xfce4-terminal")
Do I missing smth in it?

from rimpy.

Should be fixed in next release

from rimpy.

I would personally add konsole as it is the common/default for many KDE-based desktop environments, but it probably isn't possible to ever come up with any "complete" list, as there are so many. The best you can probably do is take the few most common desktop environments and distros, and include what they use as a default. Maybe even just use a Slant article for "most popular terminal emulators" or something as a quick list to build from. As this is is somewhat of a fallback solution, I wouldn't labor myself too much trying to be complete, the most common should be sufficient.

from rimpy.