Git Product home page Git Product logo

Comments (2)

Rigellute avatar Rigellute commented on May 18, 2024

This could be an interesting one.

Are there any bindings that don't currently work for you?

from spotify-tui.

jfaltis avatar jfaltis commented on May 18, 2024

I think the current bindings are very nice and appeal to the majority of users. But there are also users who might have other preferences (as you could see about the bindings for playback control #16). Having a config for keybindings would be a nice addition for users who are into customizing everything as much as they can.

My suggestion would be that the default settings/bindings (which satisfy the most users) stay in the source code and the config which is being read can overwrite certain bindings. That way the config file doesn't contain all bindings but only the ones users want to change.

Currently I would not merge the client settings into the config yet and get rid of the client.yml. I think it would be nice if you could set these in the config.yml but the client.yml should stay to make it less of a hassle for users who sync their dotfiles with other computers. This is stuff for a later PR anyways.

I think I would rename src/config.rs to src/client_config.rs and add a src/app_config.rs for keybindings and preferences (etc.).

What do you think?

from spotify-tui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.