Comments (5)
Hey @brandonvin 👋
I feel like the clojure version change was not expected in the previous commit and that part was reverted.
As you can see here, CI did not pass on that previous commit:
https://github.com/riemann/riemann/actions/runs/6698749641
The error makes me feel that the testing framework of clojure has evolved and a test that rely on the old behavior needs tuning:
Testing: riemann.test-test
Running tests in: riemann.test-test
Running test: #'riemann.test-test/only-one-tap-per-context
FAIL
Expected: (re-find #"Tap :foo \(.+?:\) already defined at :" err)
Actual: (not (re-find #"Tap :foo \(.+?:\) already defined at :" Unexpected error macroexpanding riemann.test/tap at (/tmp/form-init8155462538598659347.clj:1:6476).))
Finished test: #'riemann.test-test/only-one-tap-per-context
Fixing this should allow to update clojure. Can you give it a try and submit a PR?
from riemann.
Thanks @smortex! It might be as simple as updating the assertion, since Clojure now reports macroexpansion errors differently by wrapping them with a CompilerException. I've opened a PR: #1039.
from riemann.
I meant to come back to the blockers but never did so thanks @brandonvin! Awesome.
from riemann.
The PR is merged, thanks again for the pointers and getting the tests running!
I think it would be appropriate to keep this issue open, until the change is released.
Would it be possible to cut a release sometime soon?
from riemann.
Released in 0.3.11.
from riemann.
Related Issues (20)
- Implement InfluxDB 2.0 plugin HOT 1
- Slack notifications do not work with new slack app webhooks
- Which versions of riemann, if any, are susceptible to log4shell (log4j vulnerability)? HOT 1
- Docker image builds switched architecture HOT 2
- Store the events for riemann in an external database HOT 3
- functions using riemann.folds/count drops suddenly on high load HOT 2
- Logback needs update to 1.2.10 HOT 1
- [influxdb.clj] SSLSocketfactory not supported on JDK 9+ HOT 1
- Netty executor queue size is infinite resulting in GC pressure / OOM HOT 4
- Has 0.3.8 been retagged? HOT 1
- "Interrupted consumption" from riemann.kafka and it never recovers HOT 3
- `-XX:-StackTraceInThrowable` causes a index out of bounds exception HOT 1
- amazonica throws RuntimeException on jdk 17/18
- Expired events sometimes have the `:time` field set to a value of type `Ratio` HOT 2
- `influxdb2` keeps accumulating background threads HOT 3
- Riemann becomes unresponsive when CPU Count count is increased HOT 9
- "Throttle" is not working as expected HOT 5
- Query of `riemann streams rate` & instrumentation HOT 1
- Riemann getting lot's of error "Connection reset by peer" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from riemann.