Git Product home page Git Product logo

Comments (6)

richardszalay avatar richardszalay commented on May 20, 2024

Interesting. We definitely shouldn't be throwing a NRE, but under what situation would the actual HttpClient return null?

from mockhttp.

dday4thedeceiver avatar dday4thedeceiver commented on May 20, 2024

I don't believe it does under Windows but I've seen reports on Android, it was more completeness/exploratory testing

from mockhttp.

richardszalay avatar richardszalay commented on May 20, 2024

No problem. I'll happy accept a PR (with tests!) if you're willing/able, otherwise I'll tackle it next time I make changes to the project.

from mockhttp.

richardszalay avatar richardszalay commented on May 20, 2024

If you can provide a repro scenario where this actually happens on Android, making sure that it's not actually response.Content that's null, then I'm happy to add support myself.

from mockhttp.

guibirow avatar guibirow commented on May 20, 2024

I don't think HttpResponseMessage can be null.

In general, it should return a response with the result for the request, to describe:

  • the response status code (if it was successful)
  • the content (That could probably be null in this case or an empty stream)

from mockhttp.

richardszalay avatar richardszalay commented on May 20, 2024

I'm going to close this issue. If you can find a real world scenario where this can happen I'm happy to add support

from mockhttp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.