[Request] Improve contrast for the light theme about bamboo.nvim HOT 8 CLOSED

Thank you for the report! I agree with you that the contrast is not good enough. I took a stab at this a few weeks ago but couldn't figure out something that I was happy with. I think maybe I should look to other light themes for examples. It was difficult to get a lighter blue that was both contrasty and distinctive from the regular blue. If you have any color suggestions (or general suggestions) I am all ears! I will take another stab at this soon either way. Thank you!

Yeah, its quite hard to get light colors correct imo. The only well supported light colorscheme I have liked so far is dayfox which is part of nightfox.

Screenshots using dayfox:

Other light colorschemes which do a relatively decent job in my opinion:

• https://github.com/Verf/deepwhite.nvim (missing support for common plugins)
• https://github.com/miikanissi/modus-themes.nvim (way too much contrast)
• https://github.com/rebelot/kanagawa.nvim (too yellow, suffers from low contrast as well)
• https://github.com/catppuccin/nvim (latte flavor, way too much red/orange, good contrast though)

My absolute favorite though is https://github.com/yorickpeterse/vim-paper because it's very readable in brighter conditions, sadly it doesn't have an up-to-date implementation for nvim and very minimal plugin support but the palette choice is fantastic.

from bamboo.nvim.

Would you mind checking out this branch when you get a chance? I tried to improve the contrast a bit and I think it looks a lot better, without compromising the style. Let me know if you think it still needs changes. Also do you think the orange color needs the same treatment? Thank you for your help!

I put some general comments in this screenshot:

Edit: I notice that the comments (even in the dark palette) are intentionally kept bright (that's fine but perhaps you could add a config to lower the brightness or maybe state how to do that in the README). The issue is that comments with proper bright colors are just a distraction. Notice in the above screenshot its quite hard to say whether something is a doc comment or an inline comment. My $0.02 anyway.

from bamboo.nvim.

Thank you so much for your time and input, I really appreciate it. I think I have managed to improve on every pain point you have given (and agreed with all of them as well), except for the one about comments. I did give a small mention here on how to get traditional comment styling but maybe it should be more clear. My mindset with this theme has always been leaning towards the notion that comments are for reading (and should stand out as such). I never really was a fun of the low-contrast comment colors on most other themes; I feel like that makes more sense when treating comments as just commented-out code (which is in general bad practice). Anyways let me know if you think anything needs more improvement, or if you disagree about anything. Thank you again for your insight :)

The latest commit on your branch looks great! Don't have any more suggestions :)
As for the comment highlight, I just set it to grey as you mentioned in the README so all good there. Thank you!

from bamboo.nvim.

Thank you for the report! I agree with you that the contrast is not good enough. I took a stab at this a few weeks ago but couldn't figure out something that I was happy with. I think maybe I should look to other light themes for examples. It was difficult to get a lighter blue that was both contrasty and distinctive from the regular blue. If you have any color suggestions (or general suggestions) I am all ears! I will take another stab at this soon either way. Thank you!

from bamboo.nvim.

Thank you! I will try and take inspiration from these, especially vim-paper.

from bamboo.nvim.

Would you mind checking out this branch when you get a chance? I tried to improve the contrast a bit and I think it looks a lot better, without compromising the style. Let me know if you think it still needs changes. Also do you think the orange color needs the same treatment? Thank you for your help!

from bamboo.nvim.

Thank you so much for your time and input, I really appreciate it. I think I have managed to improve on every pain point you have given (and agreed with all of them as well), except for the one about comments. I did give a small mention here on how to get traditional comment styling but maybe it should be more clear. My mindset with this theme has always been leaning towards the notion that comments are for reading (and should stand out as such). I never really was a fun of the low-contrast comment colors on most other themes; I feel like that makes more sense when treating comments as just commented-out code (which is in general bad practice). Anyways let me know if you think anything needs more improvement, or if you disagree about anything. Thank you again for your insight :)

from bamboo.nvim.

Glad to hear; thank you again so much for all the help!

from bamboo.nvim.