Git Product home page Git Product logo

Comments (12)

kevinconaway avatar kevinconaway commented on September 26, 2024

Looks like something similar is proposed in #21

from guava-retrying.

kevinconaway avatar kevinconaway commented on September 26, 2024

@rholder any thoughts here? It looks like this has come up a few times.

from guava-retrying.

rholder avatar rholder commented on September 26, 2024

It has come up a few times. Would the PR in #21 handle your case, too?

from guava-retrying.

kevinconaway avatar kevinconaway commented on September 26, 2024

I think the implementation in this fork storecast@a13cc7d was closer to what I had in mind although I personally think it makes more sense to notify the listeners before applying the rejection predicate or stop strategory

The FailedAttemptEvent concept doesn't make sense if you want to capture successful invocations too.

from guava-retrying.

rholder avatar rholder commented on September 26, 2024

I would be in favor of a solution similar to what's in that fork. Feel free to open a PR and if you don't hear back from me on it just keep commenting until I respond.

from guava-retrying.

kevinconaway avatar kevinconaway commented on September 26, 2024

Hey @rholder any update on when this will be released?

Thanks!

from guava-retrying.

rholder avatar rholder commented on September 26, 2024

It's getting closer to a release. I've been swamped lately, but hope to block out some time this weekend.

from guava-retrying.

kevinconaway avatar kevinconaway commented on September 26, 2024

Hi @rholder any news on 1.8 or 2.0 release?

Thank you

from guava-retrying.

kevinconaway avatar kevinconaway commented on September 26, 2024

Hi @rholder, is there an ETA when this will be released?

from guava-retrying.

rholder avatar rholder commented on September 26, 2024

@kevinconaway This is for sure the next project I'm blocking out time to ship. I'm setting a personal deadline for getting a 2.0 out at the end of June (regardless of how many things don't make it in). Thanks for continuing to send me reminder feedback that there are things to do here because it helps me prioritize projects.

from guava-retrying.

rholder avatar rholder commented on September 26, 2024

Your implementation has landed in the 2.0.0 release that just went out. I'd planned to eventually be able to register listeners specifically for failure events, too, but I would rather release this now since your functionality is complete and appears to be working delightfully. I've added a @Beta annotation to give a heads up to early adopters that the API is still subject to change moving forward in case we get that in there at a later date.

from guava-retrying.

rholder avatar rholder commented on September 26, 2024

Thanks again for your contributions and relentless patience!

from guava-retrying.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.