Comments (17)
Wow, this is really convenient. I was thinking about submitting this as an issue when I first used Groupy in June, and now it's being addressed when I need to use it again.
from groupy.
Thank you! Glad you find it useful!
And I completely agree. I've learned quite a lot about software development since I originally wrote this, and this is one of those things that seems quite obvious to me now - it should just be an argument to the client's initializer.
I would certainly welcome a PR :)
from groupy.
Unfortunately, I just realized this library is GPL and that might mean I can't use it. But - I will definitely submit a PR if I come back to it!
from groupy.
🙁 Well that's not something I've run into previously... why would you not be able to use GPL projects? What licenses would be okay or better and why?
from groupy.
My understanding (might be wrong) is that anything I do on top of it under GPL has to also be open sourced, and I'm not sure the project I'm working on will be open sourced.
MIT, Apache, and LGPL are all more permissive. https://choosealicense.com/
from groupy.
Oh, I see. Very interesting read, thank you!
from groupy.
@czue you've inspired me, both to refactor the code base and to switch to the Apache license. If you're interested and willing, I can push it to a branch so you can give it a test drive. Keep in mind of course I haven't written docs or tests yet, but the code is short and simple.
from groupy.
whoa, that's amazing, thanks! definitely happy to take it for a spin! would much rather use your lib than the hacky support i cobbled together. 😄
from groupy.
Awesome! Feel free to test the latest stuffs on the feature/rewrite branch. I'll be pushing the refactored code base to that branch. Let me know if you find any bugs or if you've got some sort of use case that isn't covered and I'll see what I can do.
from groupy.
Hey - perfect timing, I was just getting ready to pick this project back up.
The new API seems great! I was able to accomplish everything I needed to from it. One tiny little thing was I had to access the group-level message summaries through Group.data['messages']
because messages
overrides the value from the raw API result, but that's totally workable.
Thanks for putting this together! Let me know if there's anything I can help with.
from groupy.
(one thing I assume you will do is to just make sure you bump the version number so pip recognizes it as a new package.)
from groupy.
Great! Glad to hear it's working out for you. I went ahead and bumped the version to 0.7.1-dev for now.
Glad you easily found the data attribute carries all the original data. I'll see about adding some properties to the Group class (and possibly others) to make accessing those often used but nested bits of data even easier.
from groupy.
Sorry for the slow pace lately, been quite busy with a new job! Anyway, I think it's about ready to document and release. Let me know if you find any additional issues and I'll get this puppy out asap.
from groupy.
Oops, I broke the Attachment
class.... fix incoming.
from groupy.
all good! i've been distracted by other things as well. really appreciate the incredible response / support on this! Let me know if anything I can do to help.
from groupy.
Finally got this done! You should be able to get v0.8.0 on PyPI now :)
from groupy.
👏 thanks!
from groupy.
Related Issues (20)
- ApiError crashing the bot HOT 12
- attachments module: import errors, not serializable HOT 3
- Mentions not serializing on Post method HOT 6
- Mentions not serializing when posting from a Bot HOT 1
- Recieve is spelled Receive
- Can't install even when Pillow is installed HOT 5
- authorization error.. anyone else? HOT 2
- Can't send messages to a chat? HOT 9
- potential parsing error on large groups HOT 2
- Like comments in a group without conversation_id? HOT 2
- Get 'likes' stats on a particular message HOT 2
- Gallery call crashes when shared Documents are in Gallery HOT 8
- API Token Validation HOT 2
- Issue with groups containing emoji in group name HOT 2
- Can't create multiple bots with no callback url HOT 6
- Adding to a group with user-id
- Adding by user id issue HOT 1
- Issue retreiving current location attachment
- How to Reply to Messages
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from groupy.