Git Product home page Git Product logo

Comments (6)

mattiasottosson avatar mattiasottosson commented on July 26, 2024

Has streamios guidelines changed for how to apply the watermark?
From stremios doc:

Add watermark image on the video.

For example, you want to add a watermark on the video at right top corner with 10px padding.

options = { watermark: "full_path_of_watermark.png", resolution: "640x360", watermark_filter: { position: "RT", padding_x: 10, padding_y: 10 } }
Position can be "LT" (Left Top Corner), "RT" (Right Top Corner), "LB" (Left Bottom Corner), "RB" (Right Bottom Corner).

I began working on a branch that will apply the watermark options in streamios doc instead, and not pass it as a video filter, didn't had time to wrap it up though.

from carrierwave-video.

artem-mindrov avatar artem-mindrov commented on July 26, 2024

This happens for me too when using an edge version of streamio-ffmpeg. This is I believe due to changes in this commit

from carrierwave-video.

rheaton avatar rheaton commented on July 26, 2024

Can either of you take a look into this and make a pull request? I'm not currently working on any projects with video transcoding, so it's hard for me to keep up with the edge versions of the gems.
Maybe we can detect the gem version and do some differently for the new one.

Thanks!

from carrierwave-video.

artem-mindrov avatar artem-mindrov commented on July 26, 2024

Is there any specific reason to set watermark option to an empty hash in defaults? If not, the necessary change would be as simple as removing it from defaults entirely.

from carrierwave-video.

shir avatar shir commented on July 26, 2024

Please take a look at PR #27

from carrierwave-video.

rheaton avatar rheaton commented on July 26, 2024

I will try to get to your PR this week. Thank you!

from carrierwave-video.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.