osx port about rhash HOT 10 CLOSED

The fix is included into RHash v1.3.6.

from rhash.

Hello.
I've read your discussion.
First, thanks for the librhash-osx.patch. The dylib libraries suuport can be merged with small changes.

Second, about cmake. Makefiles were chosen to improve portability and minimize dependency on the build system. And I want to keep that feature. Maintaining two build systems would be a hassle. So, at least for now, let other projects, incorporating librhash, maintain its cmake scripts.

from rhash.

While RHash should be built by raw makefiles by default, it's acceptable to auto-generate cmakefiles by a shell script and to distribute them in a separate directory like '/build/cmake/'.

Also note that dylib support was partly merged into librhash. Run make -C librhash dylib to build the library.

from rhash.

Current development version (master branch) allows to compile RHash for OSX using commands:

make -C librhash dylib test-dylib
make build-shared test-shared SHAREDLIB=librhash/librhash.0.dylib

from rhash.

Why does the shared library need to be specified by the user?

from rhash.

I think osx binary should not be compiled by user.
User shall use some binary package, built by some script.
The two commands above are easy enough to add to such script.

from rhash.

My concern is it seems like whoever builds the package is being asked to version the library, which doesn't seem like something they should be doing. Is it possible for rhash's build scripts to take care of the library version?

from rhash.

You are right. Fixed by commit cdaf438 ;)

from rhash.

Thank you. :)

So how should we be building RHash now?

from rhash.

I think RHash on osx should be compiled as:

configure --sysconfdir=/etc --prefix=/usr --enable-gettext
--enable-openssl-runtime --extra-cflags=-I/usr/local/opt/openssl/include"
make && make test
make instlall

from rhash.