Generates defect classes on unappropriate nullable annotations about auto-value-moshi HOT 5 CLOSED

That's interesting, I would have expected compilation to fail since that isn't a valid annotation for primitive types. What version of AV are you using?

from auto-value-moshi.

Seems like AutoValue should reject this with a compiler error before it
every reaches an extension.

On Wed, Oct 26, 2016, 3:50 PM Paul Woitaschek [email protected]
wrote:

It just took me 1 hour to detect a stupid bug where my project wouldn't
compile.

I had method of a primitive type annotated as @nullable.
The generated adapter was checking

if(value.primitiveField() != null){
...

I think the appropriate behavior for this extension would be to simply
ignore the annotation on nullable methods.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#65, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAEEEWbI05sXgxpTMtTeusgbmQDefxW8ks5q32i7gaJpZM4KhREG
.

from auto-value-moshi.

Im using Auto Value 1.3. It actually broke my build but I just got 100 cryptic warnings about missing databinding classes.

from auto-value-moshi.

Yeah, that's a different issue. https://code.google.com/p/android/issues/detail?id=208978

So it sounds like AutoValue might have been failing when you built, but I'm not sure where the value.primitiveField() != null would come from.

from auto-value-moshi.

Nothing further actionable here, but please comment if there is

from auto-value-moshi.