Use two-way binding about svelte-headlessui HOT 5 CLOSED

Agreed! We are actively using this. I'd love to help out too. I understand the desire to align with upstream, but I think some concessions would be greatly appreciated. How can I help?

From a technical perspective it's a simple change. But since you ask... one thing that would be helpful if you or anyone else have a little time is converting some of the unit tests to using svelte-inline-compile, the way this test here does:

Most of the tests were written before I discovered this library existed (it only had like 1 star on GH at the time), so I wrote my own component called TestRenderer to use my own custom syntax for testing multiple components together:

However I'd like to convert these tests to using svelte-inline-compile eventually, because the syntax is much better, and it can handle some things that aren't possible using my TestRenderer. One of those is bind:. I think in order to test bind: properly, a test method will want to use a store and then bind to it in the component.

The components that will be affected by this issue are Listbox, RadioGroup, Switch, and Tabs, so the tests there that involve changing the values will be the ones that are highest priority to convert. But I'd welcome any PRs to convert any of the tests from the old TestRenderer, if anyone feels so inclined.

(edit: this is done now)

from svelte-headlessui.

I concur, building it the svelte is the way forward.

from svelte-headlessui.

Agreed! We are actively using this. I'd love to help out too. I understand the desire to align with upstream, but I think some concessions would be greatly appreciated. How can I help?

from svelte-headlessui.

It seems to me that this issue carries utmost importance. I keep going back and forth the documentation to remind myself how React implementation of a Svelte binding is written, namely on:change assign e.details to the value (??). And tbh, I use Vue versions of the snippets because of the import statements and all that, not React.

from svelte-headlessui.

Version 2.0.0 is now published with this change.

from svelte-headlessui.