Comments (3)
Thanks for the report! Very helpful. I was able to reproduce the two issues I think you're talking about:
as
for labels is not working. This is a bug; it's because the Label component isn't using the<Render>
component when it should be:class
for labels is not reactive. This is also a bug; this line should be reactive:
I think Labels didn't get as much testing because they're a separate component from the "main" components + the upstream library doesn't really have many tests for them. I'll try to add some more unit tests with the fixes. The as
and class
props do work in general, eg they work correctly for the RadioGroupDescription in the same example.
I'm pretty busy today but I hope to fix this over the weekend.
from svelte-headlessui.
Don't worry take your time, you've done great work.
I saw you mentioned Svelte Material UI, maybe more inspiration can be drawn from Renderless Svelte and Carbon Components Svelte
from svelte-headlessui.
Thanks for the report! This will be fixed in the next release later today.
from svelte-headlessui.
Related Issues (20)
- component disappears after refresh when used in a svelte component HOT 1
- Support for @headlessui/tailwindcss HOT 1
- List box doesn't position absolute HOT 1
- Support Svelte 4 HOT 14
- Can't bind popover's "open" prop to a boolean HOT 1
- Switch not toggling
- RadioGroup and Listbox do not work properly when used together
- Can you readd on:change for listbox, etc
- Typo in Tabs Component Page
- Typescript Error 2322 when assigning object to ListboxOption value parameter
- Dialog breakes SvelteKit client-side routing HOT 2
- Conflicts in Svelte resolve
- Tree shaking HOT 1
- Time to update svelte? HOT 1
- Dialog nested in a Menu automatically opens when Menu opens
- warning when using sveltekit v2: The following packages have a svelte field in their package.json but no exports condition for svelte. HOT 1
- Missing close event on Menu
- Headless UI v2.0.0-alpha released
- Popover not detecting content click events (links / otherwise) in web component context (with fix) HOT 2
- Tabs: adding/removing tab work not properly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from svelte-headlessui.