Comments (4)
thestelz
commented on June 11, 2024
2
So I was going to take a stab at this, but I either have an issue with my environment or something is wrong with the gemspec.
I ran rubocop and got:
Error: unrecognized cop or department Layout/LineContinuationLeadingSpace found in .rubocop.yml
Did you mean `Layout/MultilineOperationIndentation`?
I then wanted to confirm the right version of rubocop that was installed:
rubocop -v
1.28.2
That is when I realized that in the gemspec, it has spec.add_development_dependency "rubocop", "~> 1.36.0", so I ran a bundle install. Then got:
bundle install
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Bundler could not find compatible versions for gem "ruby":
In Gemfile:
ruby
rgeo was resolved to 3.0.0.pre.rc.3, which depends on
ruby (>= 2.5.0)
rubocop (~> 1.36.0) was resolved to 1.36.0, which depends on
ruby (>= 2.6.0)
In the gemspec it has spec.required_ruby_version = ">= 2.5.0", so should that be bumped up or am I doing something incorrectly?
On a side note, it doesn't appear I can install 2.6.0 either, but that might be an issue with my system.
rbenv install 2.6.0
Downloading ruby-2.6.0.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.6/ruby-2.6.0.tar.bz2
Installing ruby-2.6.0...
BUILD FAILED (macOS 12.6 using ruby-build 20211227)
Inspect or clean up the working tree at /var/folders/s7/ghx09h6s7j7flwp1hvjmqsp00000gn/T/ruby-build.20221014122627.85939.xRPfVh
Results logged to /var/folders/s7/ghx09h6s7j7flwp1hvjmqsp00000gn/T/ruby-build.20221014122627.85939.log
Last 10 log lines:
transform_mjit_header: SKIPPED to transform __inline_isfinitel
transform_mjit_header: SKIPPED to transform __inline_isfinited
transform_mjit_header: SKIPPED to transform __inline_isfinitef
transform_mjit_header: SKIPPED to transform __darwin_fd_clr
transform_mjit_header: SKIPPED to transform __darwin_fd_set
transform_mjit_header: SKIPPED to transform __darwin_fd_isset
transform_mjit_header: SKIPPED to transform __darwin_check_fd_set
transform_mjit_header: SKIPPED to transform __sputc
transdb.h updated
ln -sf ../../../.ext/include/-darwin21/rb_mjit_min_header-2.6.0.h include/ruby-2.6.0/-darwin21/rb_mjit_min_header-2.6.0.h
from rgeo.
BuonOmo
commented on June 11, 2024
1
Thank you very much for working on that!
In the gemspec it has spec.required_ruby_version = ">= 2.5.0", so should that be bumped up or am I doing something incorrectly?
You can definitely bump that to 2.6.0, maybe even 2.7.0 since 2.6 is now past EOL. @keithdoggett would that be good for you ?
On a side note, it doesn't appear I can install 2.6.0 either, but that might be an issue with my system.
You should hopefully be good with at least ruby 2.7. But you're making a good case here, I think you should try ruby 2.7, 3.0, 3.1 and 3.2 with rubocop when doing the PR to ensure that it is always fine. Although, this is not mandatory at all.
from rgeo.
keithdoggett
commented on June 11, 2024
1
Thanks for taking a look at this!
@BuonOmo I agree if it's past EOL we shouldn't worry about supporting it IMO.
from rgeo.
thestelz
commented on June 11, 2024
It appears something might be wrong with my setup
ruby -v
dyld[18069]: Library not loaded: '/usr/local/opt/gmp/lib/libgmp.10.dylib'
Referenced from: '/Users/andrew/.rbenv/versions/2.7.2/bin/ruby'
Reason: tried: '/usr/local/opt/gmp/lib/libgmp.10.dylib' (no such file), '/usr/local/lib/libgmp.10.dylib' (no such file), '/usr/lib/libgmp.10.dylib' (no such file)
zsh: abort ruby -v
I'll see if I can figure out what is going on here and hopefully be able to get this issue taken care of.
from rgeo.
Related Issues (20)
- Change CAPI data wrappers
- Spherical Math/Geometry Improvements
- RGeo::Geographic.simple_mercator_factory ignores lenient flags HOT 7
- Make CAPI wrapped pointers movable HOT 2
- Set Precision for Coordinates HOT 4
- Create Documentation for Adding GEOS Functions to CAPI and FFI Implementations
- C Styleguide
- uby HOT 1
- CAPI stress test under low memory
- Polygon centroid has different SRID
- Concurrency problems with single app-wide factory? HOT 1
- rgeo 3 geom freeze behaviour HOT 3
- Expand classes in `CoordSys` module HOT 1
- Proj Rework: Clean up Core Gem
- Geos not supported HOT 3
- Geos not supported HOT 7
- `test_invalid_polygon_duplicate_rings` test is failing HOT 3
- Add Supported Geos Versions to CI
- `make_valid` throwing errors HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rgeo.