Git Product home page Git Product logo

Comments (5)

mckellyln avatar mckellyln commented on May 28, 2024

% go version
go version go1.10 linux/amd64
% grv --version
GRV - Git Repository Viewer v0.1.2-16-g36497eb (commit: 36497eb, compiled: 2018-02-25 12:57:00 EST)
Ubuntu 16.04+hwe with 4.13.0-37 kernel

from grv.

mckellyln avatar mckellyln commented on May 28, 2024
#0  main.DetermineRenderedCodePoint (codePoint=9, column=54, config=..., renderedCodePoints=...)
    at /home/<user>/go/src/github.com/rgburke/grv/cmd/grv/window.go:533
#1  0x00000000005d928f in main.(*TableFormatter).textWidth (colIndex=3, column=44, rowIndex=17, tableFormatter=0xc42002a140, width=63)
    at /home/<user>/go/src/github.com/rgburke/grv/cmd/grv/table_formatter.go:235
#2  0x00000000005d90fb in main.(*TableFormatter).determineMaxColWidths (border=true, tableFormatter=0xc42002a140)
    at /home/<user>/go/src/github.com/rgburke/grv/cmd/grv/table_formatter.go:220
#3  0x00000000005d8e6c in main.(*TableFormatter).PadCells (border=true, err=..., tableFormatter=0xc42002a140)
    at /home/<user>/go/src/github.com/rgburke/grv/cmd/grv/table_formatter.go:180
#4  0x00000000005d8a6f in main.(*TableFormatter).Render (border=true, err=..., tableFormatter=0xc42002a140, viewStartColumn=1, win=...)
    at /home/<user>/go/src/github.com/rgburke/grv/cmd/grv/table_formatter.go:144
#5  0x0000000000593308 in main.(*CommitView).Render (commitView=0xc42015c180, err=..., win=...)
    at /home/<user>/go/src/github.com/rgburke/grv/cmd/grv/commit_view.go:137
#6  0x00000000005a2c66 in main.(*ContainerView).renderWindowView (childPosition=0xc420d0b0e0, childView=..., containerView=0xc4200d0210,
    ~r2=0xc42015c180, ~r3=...) at /home/<user>/go/src/github.com/rgburke/grv/cmd/grv/container_view.go:388
#7  0x00000000005a207a in main.(*ContainerView).Render (containerView=0xc4200d0210, err=..., viewDimension=..., wins=...)
    at /home/<user>/go/src/github.com/rgburke/grv/cmd/grv/container_view.go:282
#8  0x00000000005a2205 in main.(*ContainerView).Render (containerView=0xc4200d02c0, err=..., viewDimension=..., wins=...)
    at /home/<user>/go/src/github.com/rgburke/grv/cmd/grv/container_view.go:291
#9  0x00000000005e63ad in main.(*View).Render (err=..., view=0xc42017c0c0, viewDimension=..., wins=...)
    at /home/<user>/go/src/github.com/rgburke/grv/cmd/grv/view.go:164
#10 0x00000000005b634f in main.(*GRV).runDisplayLoop (displayCh=0xc42016c000, errorCh=0xc4200a0600, exitCh=0xc4200a25a0, grv=0xc42015c280,
    waitGroup=0xc4200bf460) at /home/<user>/go/src/github.com/rgburke/grv/cmd/grv/grv.go:352
#11 0x000000000047bd01 in runtime.goexit () at /usr/local/go/src/runtime/asm_amd64.s:2361

from grv.

mckellyln avatar mckellyln commented on May 28, 2024
529     // DetermineRenderedCodePoint converts a code point into its rendered representation
530     func DetermineRenderedCodePoint(codePoint rune, column uint, config Config) (renderedCodePoints []RenderedCodePoint) {
531             if !unicode.IsPrint(codePoint) {
532                     if codePoint == '\t' {
533                             tabWidth := uint(config.GetInt(CfTabWidth))
534                             width := tabWidth - ((column - 1) % tabWidth)
535
536                             for i := uint(0); i < width; i++ {
537                                     renderedCodePoints = append(renderedCodePoints, RenderedCodePoint{

from grv.

rgburke avatar rgburke commented on May 28, 2024

@mckellyln Thanks for providing so much detail. This bug was fixed by f537cc9 and should be fixed in the latest release of grv (v0.1.3) or using the latest code on master. Could you update the grv version you're using and confirm if the issue is no longer present?

from grv.

mckellyln avatar mckellyln commented on May 28, 2024

Yes, thanks, it's fixed now.
% grv --version
GRV - Git Repository Viewer v0.1.3-23-g77433ac (commit: 77433ac, compiled: 2018-03-25 09:20:08 EDT)
Closing issue as fixed.

from grv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.