Git Product home page Git Product logo

Comments (7)

rgburke avatar rgburke commented on May 28, 2024

Thanks for pointing this issue out and for trying GRV, I really appreciate it. Some changes have been made to get GRV to build on a Mac, however they're a little bit hacky.

The readline directory path has been hardcoded as /usr/local/Cellar/readline/7.0/ at the top of readline.go. This works on my Mac and hopefully should on yours, however it assumes you use homebrew and have the Cellar directory in /usr/local/. You may potentially need to change this file path to get it to build.

I will look into a way to determine these paths in the Makefile and pass them as build arguments to avoid any manual configuration in future.
On a separate note, the selected lines in GRV don't dim on the Mac (using iTerm2), so I'll investigate why ncurses is behaving differently between Linux and Mac.

from grv.

hypnoglow avatar hypnoglow commented on May 28, 2024

Thanks, I changed path in readline.go and it finally compiled.
Btw, I think the path should be changed for a compatible variant /usr/local/opt/readline, as brew info states:

ή brew info readline
readline: stable 7.0.3 (bottled) [keg-only]
Library for command-line editing
https://tiswww.case.edu/php/chet/readline/rltop.html
/usr/local/Cellar/readline/7.0.3_1 (46 files, 1.5MB)
  Poured from bottle on 2017-05-23 at 16:48:22
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/readline.rb
==> Caveats
This formula is keg-only, which means it was not symlinked into /usr/local,
because macOS provides the BSD libedit library, which shadows libreadline.
In order to prevent conflicts when programs look for libreadline we are
defaulting this GNU Readline installation to keg-only..

For compilers to find this software you may need to set:
    LDFLAGS:  -L/usr/local/opt/readline/lib
    CPPFLAGS: -I/usr/local/opt/readline/include

from grv.

 avatar commented on May 28, 2024

+1 for /opt. Just faced this exact same problem.
Also please add a hint to your readme that people need to install homebrew and readline on OSX.

from grv.

rgburke avatar rgburke commented on May 28, 2024

Thanks for the feedback and help with this guys, #6 has been merged and I've updated the README.

from grv.

raylu avatar raylu commented on May 28, 2024

sorry if this is the wrong place to report

$ go version
go version go1.9.4 darwin/amd64

$ git show
commit ffbd489206c5e76b5c2e7ac251f088880678ea06 (HEAD -> master, tag: v0.1.2, origin/master, origin/HEAD)
Author: Richard Burke <[email protected]>
Date:   Wed Feb 7 20:15:05 2018 +0000

$ make
[...]
go build github.com/rgburke/grv/cmd/grv/vendor/gopkg.in/libgit2/git2go.v25: invalid pkg-config package name: --static
make[1]: *** [install-static] Error 1
make: *** [build-libgit2] Error 2

$ go build --tags static -ldflags "-X 'main.version=v0.1.2-0-gffbd489' -X 'main.headOid=ffbd489' -X 'main.buildDateTime=2018-02-07 13:37:56 PST'" -o grv ./cmd/grv
go build github.com/rgburke/grv/cmd/grv/vendor/gopkg.in/libgit2/git2go.v25: invalid pkg-config package name: --static

from grv.

rgburke avatar rgburke commented on May 28, 2024

@raylu Thanks for reporting this. Could you create a new issue for this please?

from grv.

raylu avatar raylu commented on May 28, 2024

done! #38

from grv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.