Git Product home page Git Product logo

Comments (2)

Rezmason avatar Rezmason commented on May 14, 2024

Thanks for your interest in the project!

You're rightfully confused, this is confusing and I should change it.

These are RGB colors, with zero representing black and one representing white. The reason they're sometimes more than one is because the colors can exist outside RGB space, which helps them be really bright.

That's not supported in the HSL versions of these colors, which is another hint that this is the wrong approach.

I'll change this shortly so that backgroundColor, glintColor and cursorColor are all colors within their color space, and separately, something like glintIntensity and cursorIntensity amplify their brightness.

glintBrightness (and glintContrast) already exist, and factor into the glint in an earlier step of the pipeline, which confuses things. This is what I get for supporting fifty properties in the config. I'll work something out.

In the meantime, just know that these RGB values operate in the zero-is-black, white-is-one range.

from matrix.

ptdev avatar ptdev commented on May 14, 2024

Ah, that is it then.

I assumed it would be 0-1, was just confused about the higher values and had no idea that colors could exist outside of the rgb color space.

But your reply clarified it. And thanks for adding/supporting those 50 config options. ❤️
Even when a little confusing, being able to configure this effect greatly enhances it

Cheers and thanks again. 👍
Closing the issue

from matrix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.