Build revery with esy on mac failed about revery HOT 9 CLOSED

To unlock this issue you can try to disable this warning revery-ui/esy-skia@91c98f6#diff-933aa78c9e01ab7dd2b1157984ff8758bf86fe1de581a8df999effb612518726 and consume your own resolution (see in package.json)

from revery.

revery-ui/esy-skia@91c98f6

Sorry, I don't know how to apply it.

from revery.

@blithefeng I'm afraid I don't have an up-to-date macOS to test this with, but try to clone this. See if it builds. If it does, let me know then I'll merge it and you can then add a resolution to that. If it doesn't, and it's another warning that fails, take the warning name, add no- in front of it, then add it to gn/BUILD.gn as shown in the PR above, and try to build again.

Also, can you show me what clang --version prints?

from revery.

@glennsl I have had the same trouble, but I can solved it with fixing package.json as below.

-    "esy-skia": "revery-ui/esy-skia#1c81aac",
+    "esy-skia": "glennsl/esy-skia#fix\/clang-warns",

thanks!

from revery.

Yeah, that should do it. Could you give me the result of running clang --version so that I can get this merged, then you can point to a commit on master and not have to worry about the branch going away.

from revery.

@glennsl OK. clang --version is as follows.

Apple clang version 13.0.0 (clang-1300.0.29.3)
Target: x86_64-apple-darwin20.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

from revery.

Thanks! I've merged the fix to esy-skia, but am not able to fix reveryitself because of some deeper dependency issues on master. But if you have a project that uses a version of revery without these issues, adding this to package.json should at least fix the issue with èsy-skia`:

  "resolutions": {
    "esy-skia": "revery-ui/esy-skia#b8aff12"
  }

from revery.

Thansk a lot. I'll try

from revery.

No problem. I don't think this is resolved and should be closed though. Revery itself is still broken. This is just a workaround.

from revery.