Git Product home page Git Product logo

Comments (5)

leiradel avatar leiradel commented on May 24, 2024

The SDL2 submodule is there only for the header files, and it's not my intention to build it along with RALibretro. I agree we need to document what is needed to properly debug RALibretro though.

The dl-cores.sh script, which must be run from the repository root folder, will download the supported cores into the bin/Cores folder. I also don't see value in downloading cores as part of the build process, this should also be explained somewhere.

from ralibretro.

rzumer avatar rzumer commented on May 24, 2024

I didn't notice the download script there. A separate script to handle dependencies sounds fine, and probably makes sense on Linux using make, but I personally prefer including that in the build process, only downloading files if they are not present.

from ralibretro.

meleu avatar meleu commented on May 24, 2024

compiling the cores can possibly add more stuff to handle, their dependencies, etc...
That's why we chose to download the ones built by the libretro's buildbot.

from ralibretro.

rzumer avatar rzumer commented on May 24, 2024

I noticed that in the develop branch, Windows dependencies are vendored. This is a bad idea. It increases the size of the repository significantly and needs to be synchronized regularly. I recommend documenting Windows dependencies and porting the fetching script to Windows as a first step, then cleaning the branch's history by deleting it and remaking it on the next release.

from ralibretro.

rzumer avatar rzumer commented on May 24, 2024

Closed by #37 as far as I can tell, though more detail could be useful.

from ralibretro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.