Show stopping bugs in `rethinkdb.logger` about rethinkdb-python HOT 6 CLOSED

@grandquista @mehaase Can we close this issue?

from rethinkdb-python.

The first issue is resolve in this commit (now on master): 96b991c

But the second and third issues are not resolved. What do you think @gabor-boros @grandquista?

from rethinkdb-python.

I will look at removing the call for the second issue. The third is a symptom of trying to get a handle on how exceptions were used internally. When we started this refactor there were a number of places that swallowed all exceptions. Or simply caught a re raised.

_{Sent with GitHawk}

from rethinkdb-python.

The second issue is solved. At the same time I namespaced our logger to help moving forward. For the third I think we want to ensure all our logging is done at the DEBUG level. I'm basing this on Django where turning up to that level gets me all the Postgres events. Write to console is mostly for ease of testing. It could be replaced with a good set of mock utilities.

from rethinkdb-python.

Thanks @grandquista for working on the second issue!

For the third I think we want to ensure all our logging is done at the DEBUG level.

Agreed.

Write to console is mostly for ease of testing. It could be replaced with a good set of mock utilities.

Can you explain this a bit more? Pytest will automatically display log messages for all failing test cases. Here's an example:

import logging

logger = logging.getLogger()

def test_always_passes():
    logger.debug('this test always passes')
    assert True

def test_always_fails():
    logger.debug('this test always fails')
    assert False

Pytest can be configured to display debug logs:

> pytest test_foo.py --log-level debug
============================ test session starts ============================
platform linux -- Python 3.6.7, pytest-4.2.0, py-1.8.0, pluggy-0.9.0
rootdir: /home/mhaase/code/hyperiongray/rethinkdb-python, inifile: setup.cfg
plugins: cov-2.6.1
collected 2 items                                                                                                         

test_foo.py .F                                                         [100%]

================================= FAILURES ==================================
_____________________________ test_always_fails _____________________________

    def test_always_fails():
        logger.debug('this test always fails')
>       assert False
E       assert False

test_foo.py:11: AssertionError
----------------------------- Captured log call -----------------------------
test_foo.py                 10 DEBUG    this test always fails
===================== 1 failed, 1 passed in 0.03 seconds ====================

Or did I misunderstand the comment about testing?

from rethinkdb-python.

Can you explain this a bit more?

As you mentioned, only for failing cases. Sometimes output from successful tests was important.

It is mostly an internal duplication of tee, and was helpful during large scale refactoring.

from rethinkdb-python.