Git Product home page Git Product logo

Comments (4)

deontologician avatar deontologician commented on July 20, 2024

Hmm, maybe the listener is getting killed

from horizon.

dalanmiller avatar dalanmiller commented on July 20, 2024

Nope, all my fault. The changed.new_val got me again. The onChanged function above should be this:

onChanged: (changed) => {
     this.todos = this.todos.map((todo) => {
      return todo.id !== changed.new_val.id ? todo : Utils.extend({}, todo, changed.new_val);
     });
     this.inform();
},

from horizon.

coffeemug avatar coffeemug commented on July 20, 2024

I think onChanged should call a callback with two arguments (new and old values), instead of a single argument that combines both into an object.

from horizon.

coffeemug avatar coffeemug commented on July 20, 2024

Err, these are observables and I should be embarrassed and ashamed of myself for the comment above (which I am).

from horizon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.