Comments (6)
Greetings and salutations,
Yeah, the formidable object isn't exposed right now, primarily because multi-part form data was put in restify to enabled APIs and curl -F, not really for file uploads. That said, it's probably not a stretch to factor it in such a way that you can get both, so I'll use this ticket as a "go refactor said code" ticket :)
m
from node-restify.
👍 - Haven't taken look at the latest commits, but have you thought anymore about adding support for file uploads. It's the one thing keeping me from moving away from Express.
Thanks for the great framework btw.
from node-restify.
I was actually going to close this out today. With the new 1.0 branch (which I'm going to officially cut over to today or tomorrow), this is no longer a problem as you would be free to do:
server.post('/foo', function (req, res, next) {
// Do whatever you want with formidable here
});
I.e., restify is no longer locking up the multipart parsing on you (unless you explicitly load the plugin it ships with). Will that suffice for what you need here?
from node-restify.
That's exactly what I was looking for and I suspect would work for most use cases.
from node-restify.
Yep - Resolved.
from node-restify.
This works when you use the following:
curl -F "[email protected]" localhost:8080/upload
When I use the following:
curl -T mydocument.docx localhost:8080/upload
Either it hangs, or it says {"message":"Unsupported Content-Type: application/octet-stream"}
However, I had thought that restify does support octet-stream?
My code is like this:
server.put('/upload', respond);
server.post('/upload', respond);
function respond(req,res,next) {
console.log(req.files);
res.send('hello ');
}
and the console says 'undefined' for echoing req.files.
from node-restify.
Related Issues (20)
- package.json's "engines" says `"node": ">=10.0.0"` but actual base version is v14.18.0 HOT 2
- Upgrade formidable dependency to resolve npm warning HOT 1
- New async/await handler support breaks `next(false)` functionality in current async handlers HOT 16
- ResourceNotFound with parameter length greater than 100
- Error when response already destroyed
- Using return in Async handlers logs entire response object to stdout HOT 4
- Allow overriding log in `plugins/audit`
- socket close on request done ?
- prePath middleware strips multiple slashes to an empty string
- An odd request can crash the process when `restify.pre.sanitizePath()` is used
- Does officially support Nodejs V18? HOT 1
- request/response serializers behave incorrectly for auditLogger plugin and Bunyan logger HOT 1
- handler error when running benchmark
- Is this repo actively maintained ?
- Restify support for nodejs v20 is merged but not released HOT 5
- Is restify.plugins.bodyParser's maxBodySize setting actually doing anything?
- v11.2.0 is not available at NPM HOT 4
- Migration from 8.5.1 to 10.0.0 causing issues
- bunyan is unmaintained, move to pino?
- Res.redirect won't work for async routes at all?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-restify.