Git Product home page Git Product logo

Comments (3)

mcavage avatar mcavage commented on May 1, 2024

So, short answer, no there's not currently a way to do this. That said, I can fix it in the next day or two.

Longer answer: 'accept' does work, but it drives "accept", not content-type for sending data. You're sending data in that custom type, not asking for it back in a custom type (if you did 'curl -is -H "Accept: application/x-chess-pgn" http://localhost:3020/pgn' restify wouldn't have choked). Currently it's hardcoded to parse out multipart/form-url/json.

What I've been meaning to do is to have you be able to specify a handler for each type, if you want it out of the way, and just ship defaults for the ones that are there. But that's a little bit of code refactoring - anyway, I'll knock that out soon.

from node-restify.

mcavage avatar mcavage commented on May 1, 2024

Ok, I put in support for this (see the commit above). Basically, if you want to "fully" support what you described above, do this:

var assert = require('assert');
var restify = require('restify');

 var server = restify.createServer({
   contentHandlers: {
     'application/x-chess-pgn': function(body) {
       assert.ok(body);

       return JSON.parse(body);
    }
  },
  contentWriters: {
    'application/x-chess-pgn': function(obj) {
      assert.ok(obj);

      return JSON.stringify(obj);
    }
  },
  accept: ['application/json', 'application/x-chess-pgn']
});

server.post('/pgn', function(req, res, next) {
  res.send(200, {success: true});
  return next();
});

server.listen(3020);

To pick this up, it's npm published as v0.3.8; I finally got around to reworking accept header handling, mostly because it choked on some simple tests I threw at it :).

Let me know if this works for you, and thanks for using restify!

m

from node-restify.

fnogatz avatar fnogatz commented on May 1, 2024

Hi Mark!
It's working now like a charm! Now I can parse files of different content-types. Thanks for your commit and support!

from node-restify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.