Git Product home page Git Product logo

Comments (10)

PatrickTulskie avatar PatrickTulskie commented on May 29, 2024 2

@steveklabnik thanks! Re-ran the CI and it looks like we're good to go on head for almost everything. Got something new to look into but at least the issues here seem resolved. Really appreciate it!

from resque.

jeremyevans avatar jeremyevans commented on May 29, 2024 1

@level_override is set in Logger#initialize. The only thing that comes to mind that could cause this is someone is overriding Logger#initialize and not calling super.

from resque.

PatrickTulskie avatar PatrickTulskie commented on May 29, 2024 1

Thanks @yahonda. I'll probably bump the mono_logger dependency once there's a new release on rubygems in a 2.6.x release so that we have baseline ruby 3.3 support.

from resque.

sambostock avatar sambostock commented on May 29, 2024

Good tip @jeremyevans. I think I've found (and tentatively fixed) it: steveklabnik/mono_logger#12

from resque.

sambostock avatar sambostock commented on May 29, 2024

https://github.com/Shopify/job-iteration/actions/runs/4185456672/jobs/7252537151 now passes with Ruby HEAD & my branch of mono_logger, which is where I noticed the issue.

from resque.

yahonda avatar yahonda commented on May 29, 2024

Thanks for the fix.

Confirmed steveklabnik/mono_logger#12 addresses this issue
by setting Gemfile as follows.

$ git diff
diff --git a/Gemfile b/Gemfile
index b78f7439..cbb5bde5 100644
--- a/Gemfile
+++ b/Gemfile
@@ -15,3 +15,4 @@ gem "rack-test", "~> 2.0"
 gem "rake"
 gem "rubocop", "~> 0.80"
 gem "pry"
+gem "mono_logger", github: "sambostock/mono_logger", branch: "ruby-head-support"
$

from resque.

zzak avatar zzak commented on May 29, 2024

Also confirmed adding this to rails Gemfile fixes the Active Job tests on Ruby 3.3.0 🙏

from resque.

PatrickTulskie avatar PatrickTulskie commented on May 29, 2024

If I'm understanding this correctly, this was resolved in mono_logger. Any objection to closing out this issue?

from resque.

yahonda avatar yahonda commented on May 29, 2024

Correct. Closing this issue. Thank you for the notification.

from resque.

steveklabnik avatar steveklabnik commented on May 29, 2024

@PatrickTulskie shipped 1.1.2, you should be able to update, let me know if you run into any more issues.

from resque.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.