What would be the best way to call socket.setTimeout? This would be

Seems like this should work, though it's a bit hacky: <div class="highlight highli

socket.setTimeout for foreverAgent about forever-agent HOT 2 OPEN

request commented on July 20, 2024

socket.setTimeout for foreverAgent

from forever-agent.

Comments (2)

CrabDude commented on July 20, 2024

Seems like this should work, though it's a bit hacky:

var ForeverAgent = require('request/node_modules/forever-agent');

// Set inactive socket timeout by shimming createConnection
var createConnection = ForeverAgent.prototype.createConnection;
ForeverAgent.prototype.createConnection = function() {
  var socket = createConnection.apply(this, arguments);
  socket.setTimeout(Config.foreverAgent.timeout);
  return socket;
};

Would be nice if this were exposed via agentOptions.timeout. Open to a pull request?

from forever-agent.

CrabDude commented on July 20, 2024

For posterity, looks like socket.setTimeout is a no-op in that you have to close the socket yourself. Here's the working code I ended up with:

var ForeverAgent = require('request/node_modules/forever-agent');

// Set inactive socket timeout by shimming createConnection
var createConnection = ForeverAgent.prototype.createConnection;
ForeverAgent.prototype.createConnection = function() {
  var socket = createConnection.apply(this, arguments);
  socket.setTimeout(Config.foreverAgent.timeout || 0, socket.end.bind(socket));
  return socket;
};

It looks like we're going to need per-service (host:port) timeouts though, so I'll need to fork forever-agent (and submit a pull request), will update here.

from forever-agent.

Recommend Projects