Comments (3)
It just feels a little weird to have an options object when there is only one option. I'm trying to think of another case where we might need an option though.
from caseless.
@mikeal while I agree that it feels weird I think it is a positive change in terms of code readability. I, as most developers, read docs when I'm trying to use a certain feature, but when reading someone else's code I usually guess by the API what the method is doing.
So, in this particular case, I would expect a key, value params in a setter method, but a third param as boolean is not intuitive at all.
So, just my two cents, feel free to close this issue if you think it is useless.
Best,
Max
from caseless.
hrm... i think you're right, i just need to think about the best way to do this without breaking API or killing performance.
from caseless.
Related Issues (17)
- caseless.httpify generates broken getHeader
- Clarify license HOT 1
- get incorrectly matches other headers containing name
- Leaking global variable: _key HOT 3
- unable to install caseless HOT 2
- Could use `filter` and `exclude` methods
- Constructor should accept an instance of `caseless`
- License document HOT 5
- Publish latest version HOT 1
- swap function removes the header if already exists HOT 2
- release 0.9.0 removed and making automated build fail HOT 6
- License for version 0.9.0 and lower HOT 1
- del() doesn't work correctly on key duplicates HOT 1
- Typo in 'swap' error message
- The Copyright phrase is missing. HOT 2
- has is not equivalent to official HTTP APIs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from caseless.