Proposal: more flexible Function interface for non-String args about sqlite-android HOT 7 CLOSED

Thanks for the detailed issue! yes I think having a way to read arguments in a CustomFunction interface makes sense, instead of just passing them all as strings.

from sqlite-android.

Closed by #61 :)

from sqlite-android.

Please make a release with this @npurushe

And how did @dhleong solve the matchinfo parsing with this feature? Which type did you use?
I have some problems getting the matchinfo parsed correctly (signed/unsinged types! and more)
I the code you added in the inital case, kotlin? I am having trouble with this line in java: longBuf.get().toInt()

from sqlite-android.

Yep, it's kotlin. That code was the workaround for using the old Strings interface, and doesn't actually work super well in all cases, which is why I submitted the PR.

If you use the code from #61, it's much simpler. The matchinfo() function returns a Blob that you can wrap in a ByteBuffer:

          // for a call like rank(matchinfo(index, 'nlpx')):
            val buffer = ByteBuffer.wrap(args.getBlob(0))

            val totalDocsCount = buffer.int  // 'n'
            val documentSize = buffer.int  // 'l'
            val phrases = buffer.int  // 'p'

            val hitCount = buffer.int  // 'x[0]'
            buffer.int // skip x[1]
            val docsWithHits = buffer.int  // 'x[2]'

from sqlite-android.

Also, since I may have misunderstood your question and maybe you were actually not sure what the kotlin was doing, the .toInt() there was just casting the result of longBuf.get() to an int; Kotlin doesn't let you just cast between primitive types; you have to explicitly convert them.

The .int calls in the above example code actually compile to .getInt() calls on the ByteBuffer. It's part of Kotlin's automatic conversion of getters and setters to "properties."

from sqlite-android.

Thanks a lot!!
It works great with getBlob. I have spend a lot of hours to try to make the SQLiteCustomFunction work with matchinfo.
Do you know if we should use ByteOrder.nativeOrder() make sure to support all devices or just ByteOrder.LITTLE_ENDIAN for the sqlite blob?

from sqlite-android.

from sqlite-android.