Git Product home page Git Product logo

Comments (16)

emackey avatar emackey commented on June 27, 2024 1

We're still working to get a better test model for specular. The toy car is the only one available at this point, but for me at least, it's not intuitive why the car comes out that color. It would be better for us to have a model that's more explicit, but we don't have one yet.

The closest thing to ground truth currently is a prototype path tracer from Dassault. But there was a change to the specular parameters just a couple weeks ago, and I don't know if this path tracer was updated to support that yet. This should all get straightened out before we send specular over for ratification.

Live: https://dassaultsystemes-technology.github.io/dspbr-pt/

Source: https://github.com/dassaultsystemes-technology/dspbr-pt/

from redcube.

Reon90 avatar Reon90 commented on June 27, 2024 1

@cx20 fixed in 2.5.13

from redcube.

emackey avatar emackey commented on June 27, 2024 1

@cx20 Let's disregard the cloth on this particular version of the ToyCar model. Fabric and sheen effects have other tests that have already been merged into the official repo. This version of ToyCar is due to be replaced eventually. Thanks.

from redcube.

Reon90 avatar Reon90 commented on June 27, 2024

@cx20 do you have source of model, because I'm not sure about fabric material (The part of the cloth looks like a metallic luster).
When only IBL is on, the flame emblem and car number are specularly reflected. - fixed in 2.5.12

from redcube.

cx20 avatar cx20 commented on June 27, 2024

do you have source of model, because I'm not sure about fabric material

The glTF file is shown below, but you will have to ask the creator if there is an original source.
ToyCarSpecular.zip

The part of the cloth looks like a metallic luster

The areas that I see as metallic luster are as follows.
In Babylon.js, Fabric reflects the Base Color texture, but in Red Cube it appears to have a metallic luster.

Library ToyCarSpecular.gltf result
Babylon.js image
RedCube.js image

See below for the expected results of this model. Babylon.js seems to be the closest to the expected result so far.
KhronosGroup/glTF-Sample-Models#268 (comment)

from redcube.

cx20 avatar cx20 commented on June 27, 2024

When only IBL is on, the flame emblem and car number are specularly reflected. - fixed in 2.5.12

I confirmed this. Thank you for your support.

from redcube.

Reon90 avatar Reon90 commented on June 27, 2024

@cx20 Iā€™m trying to told you that Babylonjs is not source of true. To verify rendering we need some ground truth renderer, e.g. Blender etc.

from redcube.

cx20 avatar cx20 commented on June 27, 2024

Below is the result of path-traced. Perhaps this is the expected result.
KhronosGroup/glTF-Sample-Models#268 (comment)
image

Current result:
image

from redcube.

cx20 avatar cx20 commented on June 27, 2024

@emackey Any advice on how to test KHR_materials_specular?

from redcube.

cx20 avatar cx20 commented on June 27, 2024

@emackey Thanks for the advice. I have tried Dassault's path tracer.
However, unfortunately, I could not determine if that was the correct result.

Dassault's path tracer + ToyCarSpecular.gltf(using the KHR_materials_specular extension) result:
image

Since this extension is not yet finished, we may have to work on another issue first.

from redcube.

cx20 avatar cx20 commented on June 27, 2024

@Reon90 Thanks! It looks good.

result
before image
after image

from redcube.

cx20 avatar cx20 commented on June 27, 2024

@Reon90 The cloth seems dark when I view ToyCarSpecular.gltf on the latest version of RedCube. Can you confirm it?

result
RedCube 2.5.13 image
RedCube 3.0.2 image

from redcube.

Reon90 avatar Reon90 commented on June 27, 2024

fixed in 3.2.0 @cx20

from redcube.

Reon90 avatar Reon90 commented on June 27, 2024

@cx20 could you check?

from redcube.

cx20 avatar cx20 commented on June 27, 2024

I have confirmed this model again with RedCube v3.3.0. I think the cloth is brighter than before.

image

@emackey Is it possible to determine if the brightness of this cloth is correct? Personally, I don't feel so uncomfortable, so I feel that the test has passed.

from redcube.

cx20 avatar cx20 commented on June 27, 2024

@emackey Thanks for the advice.

@Reon90 I would like to ignore the effects of Fabric and sheen as advised by emackey. I marked the test as passing in gltf-test.

from redcube.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.