Git Product home page Git Product logo

Comments (3)

lildude avatar lildude commented on June 15, 2024 1

Does changing it to source.regexp.python solve the problem?

Yes as Linguist will include the file from the Python grammar that we ship.

Or I need to include a copy of regular expressions (python).cson from atom/language-python?

This would also work, but you'd need to change the scope within it to match source.regexp.python.renpy at https://github.com/atom/language-python/blob/master/grammars/regular%20expressions%20(python).cson#L2

Of the two, I'd recommend the former. That way you don't need to keep maintaining a copy and Renpy will continue to gain from the enhancements to that grammar as it evolves within the upstream grammar. I'd only recommend the latter if you plan to implement renpy-specific changes to it.

from language-renpy.

williamd1k0 avatar williamd1k0 commented on June 15, 2024

Sorry for the delay.
This was introduced in 9ac1da3

@lildude Does changing it to source.regexp.python solve the problem?
Or I need to include a copy of regular expressions (python).cson from atom/language-python?

from language-renpy.

williamd1k0 avatar williamd1k0 commented on June 15, 2024

Does changing it to source.regexp.python solve the problem?

Yes as Linguist will include the file from the Python grammar that we ship.

I believe Ren'Py won't need an alternative regex scope, so I just renamed it to source.regexp.python in c5c1777.

Thanks for helping! 👋

from language-renpy.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.