XmlEventAttribute is missing namespace about dart-xml HOT 5 CLOSED

Actually, it looks like this is the case for XmlEventStartElement too... the name should probably be an XmlName instead of a string in both cases.

from dart-xml.

True, I had it like that in my initial attempt where I reused the normal DOM nodes. The problem with XmlName is as with all the other DOM objects that many things simply don't work outside of that space (ownership navigation, namespace resolution, ...).

To keep events lightweight it would probably be the simplest to add separate accessors for the local name, the qualified name (what is currently returned), and the namespace prefix?

from dart-xml.

What do you think about adding the following mixin to the events with name:

abstract class XmlNamed {
  /// The fully qualified name.
  String get name;

  /// The namespace prefix, or `null`.
  String get namespacePrefix {
    final index = name.indexOf(XmlToken.namespace);
    return index > 0 ? name.substring(0, index) : null;
  }

  /// The local name, excluding the namespace prefix.
  String get localName {
    final index = name.indexOf(XmlToken.namespace);
    return index > 0 ? name.substring(index + 1) : name;
  }
}

from dart-xml.

If this is ok, I can make a new release with e6c0458?

from dart-xml.

I've released this as 3.3.1 on pub.

from dart-xml.