Git Product home page Git Product logo

Comments (6)

cuprous avatar cuprous commented on May 18, 2024 1

It looks like the issue is on line 11 of ElideAttributes.php:

'/disabled=[^ >]*(.*?)/' => 'disabled',

That's going to remove any expression passed to ng-disabled. Maybe it could be replaced with:

'/ disabled=[^ >]*(.*?)/' => ' disabled',

from laravel-page-speed.

cuprous avatar cuprous commented on May 18, 2024 1

@renatomarinho I didn't think of it when I commented yesterday, but you might want to consider using \s instead of the actual space character so that you catch tabs or newline characters before the disabled attribute.

'/\sdisabled=[^ >]*(.*?)/' => ' disabled',

from laravel-page-speed.

renatomarinho avatar renatomarinho commented on May 18, 2024

Hi @sensugaz ,

Can you send me an example?

from laravel-page-speed.

sensugaz avatar sensugaz commented on May 18, 2024

before
http://prntscr.com/gyxjth
<button type="submit" class="btn btn-success btn-block" ng-disabled="form.$invalid || btnLoading"> <span ng-if="!btnLoading"> ล๊อกอิน </span> <span ng-if="btnLoading"> <i class="fa fa-circle-o-notch fa-spin"></i> </span> </button>
after
http://prntscr.com/gyxka2

from laravel-page-speed.

renatomarinho avatar renatomarinho commented on May 18, 2024

thanks, @cuprous !!!

from laravel-page-speed.

sensugaz avatar sensugaz commented on May 18, 2024

thank you :)

from laravel-page-speed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.