Incoming number sent to JS listener about cordova-phone-call-trap HOT 6 OPEN

It's better to have a JSONObject with the following definition : { state:"RINGING", number:"NUMBER}

It's explicit and avoids breaking changes if you want to add caller name or any other info later.

from cordova-phone-call-trap.

+1
And caller name if in phone book :)

from cordova-phone-call-trap.

Hi @beradrian and @leonzinger

Today I have two pull requests about this.
I need study this solution because one used a json object ({"RINGING": "NUMBER}) for all states and other concatenate number on ringing state (RINGING + "NUMBER").

Do you have any preference?

from cordova-phone-call-trap.

I prefer JSON as well.

Thank you!

On Mon, Oct 26, 2015 at 11:50 AM guillaume-fr [email protected]
wrote:

It's better to have a JSONObject with the following definition : {
state:"RINGING", number:"NUMBER}

It's explicit and avoids breaking changes if you want to add caller name
or any other info later.

—
Reply to this email directly or view it on GitHub
#2 (comment)
.

from cordova-phone-call-trap.

I agree with @guillaume-fr { state:"RINGING", number:"NUMBER}. JSON is much better.

from cordova-phone-call-trap.

Hi @renanoliveira thanks for the plugin , can you pull this fix #7 .

from cordova-phone-call-trap.