Comments (4)
Yeah, there will always be some friction when adding future API without breaking the existing types. At least TypeScript has a way to override these type definitions.
In addition, I think Remix needs to add ones for the updated LoaderFunctionArgs
and ActionFunctionArgs
so that response
is not optional (since it isn't when single fetch is enabled).
from remix.
Possible fix:
Add a ClientLoaderFunctionArgs_SingleFetch
to use instead of ClientLoaderFunctionArgs
?
type ClientLoaderFunctionArgs_SingleFetch = Omit<
ClientLoaderFunctionArgs,
"serverLoader"
> & {
serverLoader: <T = AppData>() => ReturnType<T>;
};
type ClientLoaderFunction_SingleFetch = ((
args: ClientLoaderFunctionArgs_SingleFetch,
) => ReturnType<LoaderFunction_SingleFetch>) & {
hydrate?: boolean;
};
type ClientActionFunctionArgs_SingleFetch = Omit<
ClientActionFunctionArgs,
"serverLoader"
> & {
serverLoader: <T = AppData>() => ReturnType<T>;
};
type ClientActionFunction_SingleFetch = (
args: ActionLoaderFunctionArgs_SingleFetch,
) => ReturnType<ActionFunction_SingleFetch>;
Then, add it on hooks
type SingleFetchSerialize_V2<T extends LoaderFunction_SingleFetch | ActionFunction_SingleFetch | ClientLoaderFunction_SingleFetch | ClientActionFunction_SingleFetch> =
Awaited<ReturnType<T>> extends TypedDeferredData<infer D> ? D :
Awaited<ReturnType<T>> extends TypedResponse<Record<string, unknown>> ? SerializeFrom<T> :
Awaited<ReturnType<T>>;
declare module "@remix-run/react" {
export function useLoaderData<T>(): T extends
| LoaderFunction_SingleFetch
| ClientLoaderFunction_SingleFetch
? SingleFetchSerialize_V2<T>
: never;
export function useActionData<T>(): T extends
| ActionFunction_SingleFetch
| ClientActionFunction_SingleFetch
? SingleFetchSerialize_V2<T>
: never;
export function useRouteLoaderData<T>(
routeId: string,
): T extends LoaderFunction_SingleFetch | ClientLoaderFunction_SingleFetch
? SingleFetchSerialize_V2<T>
: never;
export function useFetcher<TData = unknown>(
opts?: Parameters<typeof useFetcherRR>[0],
): FetcherWithComponents<
TData extends
| LoaderFunction_SingleFetch
| ActionFunction_SingleFetch
| ClientLoaderFunction_SingleFetch
| ClientActionFunction_SingleFetch
? SingleFetchSerialize_V2<TData>
: never
>;
}
from remix.
The reason is single-fetch.d.ts
.
export function useLoaderData<T>(): T extends LoaderFunction_SingleFetch
? SingleFetchSerialize_V2<T>
: never;
export function useActionData<T>(): T extends ActionFunction_SingleFetch
? SingleFetchSerialize_V2<T>
: never;
type LoaderFunction_SingleFetch = (
args: LoaderFunctionArgs
) => Promise<DataFunctionReturnValue> | DataFunctionReturnValue;
type ActionFunction_SingleFetch = (
args: ActionFunctionArgs
) => Promise<DataFunctionReturnValue> | DataFunctionReturnValue;
Extends for the generics of useLoaderData
and useActionData
don't match with args
of clientLoader
(ClientLoaderFunctionArgs
)
from remix.
Related Issues (20)
- Hydration Errors When Deferred Promise Rejects HOT 1
- useFetcher return type is `any` since upgrading to remix 2.9.0 HOT 2
- redirect with 307 does not work as expected HOT 5
- install.js.map hook HOT 3
- 2.9.1: useFetcher/useLoaderData types are set to never HOT 8
- Single fetch `response` parameter for loader is undefined if no default export exists in the route HOT 8
- useLoaderData<typeof loader> returns type JsonifyObject<T> rather than T HOT 6
- Single Fetch Issues HOT 8
- Single Fetch: bad behavior in promises that resolve to `undefined` and `null` HOT 2
- Single fetch: loader type us unknown HOT 6
- Application crashes on unhandled promise rejection in deferred data HOT 5
- [VitePlugin] HMR breaks with imagetools transformer Vite plugin HOT 1
- Testing utilities have wrong types for meta functions HOT 1
- remix-express/server throws error on IPv6 host or X-Forwarded-Host HOT 3
- `remix dev` fails when workspace has a deprecated node-builtin in unrelated package
- Re: `@remix-run/serve` sets high `max-age` and `immutable` cache header on everything HOT 2
- Action submission triggers a loader re-validation ignoring its `shouldRevalidate` export.
- Single fetch: thrown response stub passed to `handleError` HOT 3
- Single fetch: allow setting a `nonce` on `StreamTransfer`'s `script` tags HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from remix.