Comments (4)
I hadn't ever seen it before either but when I looked up how to do module.exports
in the TypeScript docs that's how it said it should be done. AFAICT export =
is the TypeScript equivalent for ESM export default
. In TypeScript, export default
is actually a named export called default
.
from remix.
Ya, just confirmed. If I use export default loader
I get exports.default = loader
in my .js file. But export = loader
gives me module.exports = loader
in the CommonJS output.
from remix.
Any chance the code that requires the loaders could handle this case (kinda like babel's interop require thing):
function _interopRequireDefault(obj) {
return obj && obj.__esModule ? obj : { default: obj };
}
I do this in babel-plugin-macros: https://github.com/kentcdodds/babel-plugin-macros/blob/3263dbe8f9153090249fc2b8dcc4a5c6d61b6625/src/index.js#L84-L88
function interopRequire(path) {
const o = require(path)
return o && o.__esModule && o.default ? o.default : o
}
That works for babel because they set the __esModule
property. TypeScript doesn't do this, so it'd probably be better to go with something like this:
function interopRequire(path) {
const o = require(path)
return typeof o === 'object' && o.default ? o.default : o
}
I think that would be pretty safe and would allow us to avoid the odd syntax.
from remix.
This is no longer relevant
from remix.
Related Issues (20)
- ✘ [ERROR] Could not resolve "lightningcss" ONLY when running `remix dev` HOT 1
- `No match URL` error occurs. (CloudFlare Pages) HOT 2
- docs: Invalid link for `Splat Route` at `Not found handling` HOT 1
- Vite hangs on fresh npm install when using `installGlobals` HOT 4
- SPA mode index.html default meta tags HOT 1
- Issue with testing action method with multipart form data
- `maxPriorityFeePerGas` is not set when remix does `eth_sendEstimateGas`, while `maxFeePerGas` is set. If `maxFeePerGas` is set, the other should be set as well HOT 1
- Different timestamps are being appended to the link tags when preloading a CSS assets
- Relative path does not resolve correctly with flat file routes HOT 2
- Invalid manifest reports `{client,server}/.vite/manifest.json` HOT 7
- MetaArgs should be renamed to MetaFunctionArgs to match the rest of remix API types HOT 5
- "Server-only module referenced by client" after upgrading to 2.7.1 HOT 3
- Vite: ErrorBoundary with predefined links cause "Expected server HTML to contain a matching <link> in <head>."
- Remix server runs (by NX) and fails after short time without not specific error HOT 2
- When browser requests source maps, express slows down extremely in production for all Remix based apps
- Updating state in Suspense fallback component do not work as expected
- Vite fails to bundle node-postgres (`pg`) properly when used with Cloudflare template HOT 1
- Vite fails running react-dnd only in production builld HOT 2
- Graphql Aliases don't seem to work HOT 1
- useLoaderData hook issue while running in dev mode HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from remix.