Git Product home page Git Product logo

Comments (5)

brookslybrand avatar brookslybrand commented on June 13, 2024 1

I posted that and then just realized that you've already opened up #199 😅

Thanks for doing that 🤘 I'll take a look today or tomorrow and provide any feedback

from remix-website.

dendrobiummoniliforme avatar dendrobiummoniliforme commented on June 13, 2024

Gathering info:

  • Looks like this was introduced in #73

Which seemed to want to bring the pages more inline with React Router https://reactrouter.com/en/main which when a user right clicks on the React Router website logo they do get directed to https://reactrouter.com/brand which is a webpage dedicated to assets. It is not a google drive but my original thought about its usage seems correct.

Page is https://github.com/remix-run/react-router-website/blob/4b2bee1a7160d3de79b3f623aa0c5239e0f61ad9/app/routes/brand.tsx#L13 for the react-router-website

I guess the questions is:

  • Should this instead link to a brand route much like the React Router page?

from remix-website.

brookslybrand avatar brookslybrand commented on June 13, 2024

Hi @dendrobiummoniliforme, thanks for bringing this up. This is in fact expected behavior. I'm not sure where we took this from, but I've seen it done on many websites. Here is Astro for example:

astro_example.mov

While I agree we can probably give a slightly better experience than ripping you our site's context and into Google Drive, we do prefer to send you to all of the official, high quality assets if you're attempting to copy the logo.

So to your question

Should this instead link to a brand route much like the React Router page?

I think that could be cool! If this is something you're interested in taking on feel free to explore it, otherwise I can open a new issue with a more direct ask/mockup.

from remix-website.

dendrobiummoniliforme avatar dendrobiummoniliforme commented on June 13, 2024

@brookslybrand I think this is good to close 😄 as per #199

from remix-website.

brookslybrand avatar brookslybrand commented on June 13, 2024

Yep! Thanks for bringing this up and all your help @dendrobiummoniliforme :) The team is excited to have this page

from remix-website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.