Ability to access HTTP headers via Model about her HOT 7 CLOSED

There’s a non documented feature in Her that removes any parameters matching /^_/. I added a new line in the main HTTP request wrapper that allows you to pass a custom _headers variable in all HTTP/ORM methods, like so:

User.all(:type => "regular", :_headers => { "X-Page" => 2 })

This will call GET /users?type=regular with a X-Page: 2 HTTP header. Is this something you’d like to see in the library? I plan on adding it in 0.2.6.

Thanks for the request!

from her.

Awesome! Thank you for the fast response!

This is perfect for my needs on the request side, is there any way to access the response headers? The only thing missing with this change in place is a way to pull something like X-Total-Items: 500 out of the response.

Cheers!

from her.

Unfortunately, there's currently no way for an instance of a model to access the response data, other than the actual resource data.

Currently, the parser middleware must return a hash with three keys (example), data, metadata and errors — but only the data one is used by the constructor (because of lines like these that are present in a few places).

In the meantime, you could create your own parser middleware (they're very simple, check out the default SecondLevelParseJSON and FirstLevelParseJSON) that store the value env[:headers]["X-Total-Items"] in a variable that you could access later from your model.

Handling the metadata and errors keys is in the works though, I just have to come up with a backward compatible way of using them easily.

Thanks!

from her.

Gotcha, I'll come up with a way to pass that data around, thank you for the great info.

One small side problem I ran into today that perhaps should be a separate issue:

Currently the default JSON parse middleware doesn't set the 'Accept' header in the request to 'application/json'. It comes out as '*/*' this was easy to change with small bit of middleware but it would be a nice to have as a default set by the parser.

Cheers!

from her.

Alright, I'll look into it. Thank you for your help! :)

from her.

Currently the default JSON parse middleware doesn't set the 'Accept' header in the request to 'application/json'. It comes out as '/' this was easy to change with small bit of middleware but it would be a nice to have as a default set by the parser.

Actually, I thought about it and this is the kind of thing that Faraday lets you do through middleware:

class Foo < Faraday::Middleware
  def call(env)
    env[:request_headers]["Accept"] = "application/json"
    @app.call(env)
  end
end

Her::API.setup :url => "https://api.example.com" do |connection|
  connection.use Foo
  connection.use Faraday::Request::UrlEncoded
  connection.use Her::Middleware::FirstLevelParseJSON
  connection.use Faraday::Adapter::NetHttp
end

from her.

That is exactly what I did to get around it. I guess i was expecting to be
set by default by the JSON middleware as the JSON middleware is expecting
JSON so to me it would make sense that it would set the accept header as
such.

On Tue, Jun 26, 2012 at 6:55 PM, Rémi Prévost <
[email protected]

wrote:

Currently the default JSON parse middleware doesn't set the 'Accept'
header in the request to 'application/json'. It comes out as '/' this was
easy to change with small bit of middleware but it would be a nice to have
as a default set by the parser.

Actually, I thought about it and this is the kind of thing that Faraday
lets you do through middleware:

class Foo < Faraday::Middleware
 def call(env)
   env[:request_headers]["Accept"] = "application/json"
   @app.call(env)
 end
end

Her::API.setup :url => "https://api.example.com" do |connection|
 connection.use Foo
 connection.use Faraday::Request::UrlEncoded
 connection.use Her::Middleware::FirstLevelParseJSON
 connection.use Faraday::Adapter::NetHttp
end

---

Reply to this email directly or view it on GitHub:
#16 (comment)

from her.