browse schedules - some denomination/state filters not sticking about omeka-s-theme HOT 7 CLOSED

Good catch, the fix for the deletions should be in now.

from omeka-s-theme.

I removed some deprecated javascript that I think was tripping up the selected filters application. Could you see if the filters are working as they should now?

from omeka-s-theme.

So, this seems to be working properly for the Denominations, but not the States. The below screenshot is the result of me selecting a few states and applying those filters. Under "Counties", it displays a duplicate of the filtered denominations.

It looks like this when I first select the states, but the result is like the above screenshot once Apply filters is clicked.

Also, I'm noticing that when I refresh the page after removing filters and not selecting "Apply filters", the filters remain. I'm not sure if this is the behavior we want, but wanted to get your thoughts on this.

from omeka-s-theme.

Ah, I found a typo where the view is looking for the active county ids. Should be fixed!

The apply filters behavior is intended. Basically all additional changes to the dropdown need confirmation. The active filters being automatically populated are based off the URL. We could alert the user if they try to refresh without applying changes.

from omeka-s-theme.

Ah, this is working great! And yes, I think an alert asking the user if they truly want to refresh the page or not when they have active selected/deleted filters would help... Only because of the current behavior, because if the user deletes filters or refreshes the page when filters are already applied, the user may expect the filters to clear completely from refreshing.

These articles can help in this regard: http://web-accessibility.carnegiemuseums.org/code/alerts/ , https://www.w3.org/WAI/tutorials/forms/notifications/

So an alert dialog like this should suffice, but I defer to the rest of the team for appropriate wording in this case:
A filter was deleted/selected, but wasn't applied. Refreshing the page won't clear the filter. Do you still want to refresh?

buttons underneath: [Yes] [No]

from omeka-s-theme.

We actually had this functionality in the Omeka admin interface already, so I copied it over to the module handling these browse filters. The user should now get a browser alert asking if they want to leave the page with unsaved changes. (This language is provided by the browser.)

from omeka-s-theme.

This functionality works for selections, but not necessarily for deletion of a filter. Is it possible to implement this for deletions?

from omeka-s-theme.