Bug - Issue with github comment on resolved items about release-it HOT 10 CLOSED

🚀 This issue has been resolved in v17.1.1. See Release 17.1.1 for release notes.

from release-it.

Maybe fixed it, shot in the dark 🔫

from release-it.

I got green pipeline across projects :)

Thank you!

from release-it.

Green is good! piew piew 🔫

from release-it.

I have not had time to look into it, just noticed it one a release using the latest version.

from release-it.

The issue is...

file:///home/runner/work/release-it-pre-releases/release-it-pre-releases/node_modules/ora/index.js:385
		throw new TypeError('Parameter `action` must be a Function or a Promise');
		      ^

TypeError: Parameter `action` must be a Function or a Promise

From here https://github.com/sindresorhus/ora/blob/main/index.js#L384-L385

from release-it.

If it's an issue with Ora then there might be something off with --ci or CI env var not set? Otherwise you can try to set github.comments.submit to false.

Of course there can be a bug in release-it, too.

from release-it.

The action is running npx release-it --ci --git.tagExclude='*[-]*'.

from release-it.

Just in case, I tried updating the release configuration to github comments to false. See here and the commit

from release-it.

Well, it is correctly going to that scope as the --ci flag is set. Now, I am trying to understand why the this.commentOnResolvedItems() is identified as not a Promise.

from release-it.