Parameter binding on (root) queries broken in 0.7? about react-router-relay HOT 14 CLOSED

This is literally the only change between 0.6.2 and 0.7.0 though: 7221ebf. Are you sure it's not some dependency thing?

from react-router-relay.

Running into this too. Seems related to [email protected] changes.

from react-router-relay.

Okay I see it's most likely facebook/relay@6cc8f96 then.

from react-router-relay.

Err scratch that, no it's not.

from react-router-relay.

I'm puzzled - I use this pattern in my code and it works just fine.

from react-router-relay.

Are either of you using prepareParams?

from react-router-relay.

Nope.

On Tue, Nov 3, 2015 at 8:41 PM, Jimmy Jia [email protected] wrote:

Are either of you using prepareParams?

—
Reply to this email directly or view it on GitHub
#70 (comment)
.

from react-router-relay.

I'm totally stumped then. I tried a couple of variations of using this pattern locally and they all seemed to work.

from react-router-relay.

I've been meaning to set some time aside to add test coverage anyway - this is probably a good motivation. But I'd appreciate any help getting a repro for this, since I'm not sure how I'd reproduce in an automated way a bug that I can't reproduce manually.

from react-router-relay.

Okay I see it's most likely facebook/relay@6cc8f96 then.

This was my initial thought too... some quick sleuthing indicated that the routes/params were being correctly passed down by RRR, but the params themselves aren't being written out in the query on the Relay end.

from react-router-relay.

That's not new to Relay v0.4.0 or RRR v0.7.0 though.

What version of babel-relay-plugin do you have?

from react-router-relay.

A possible culprit is facebook/relay@356529f, if you haven't upgraded babel-relay-plugin to v0.3.0.

I see that Relay v0.4.0 was shipped without the peer dependency, though Relay on master now has it.

from react-router-relay.

/facepalm

Updating to 0.3.0 fixes it.

On Tue, Nov 3, 2015 at 9:15 PM, Jimmy Jia [email protected] wrote:

A possible culprit is facebook/relay@356529f
facebook/relay@356529f,
if you haven't upgraded babel-relay-plugin to v0.3.0.

I see that Relay v0.4.0 was shipped without the peer dependency, though
Relay on master now has it.

—
Reply to this email directly or view it on GitHub
#70 (comment)
.

from react-router-relay.

And - it's something that automated testing probably wouldn't have caught (since I would have upgraded everything all at once), so I feel less guilty now for not having any tests. And it's good to see the peer dependency now listed under Relay.

@justinsb It's quite likely you're hitting the same problem - I'm going to close this issue under that assumption, but let me know if it's otherwise.

from react-router-relay.