Git Product home page Git Product logo

Comments (27)

soleofthesea avatar soleofthesea commented on July 4, 2024 1

I just very quickly spun up a fresh Ubuntu VM and was able to reproduce the bug. So I don't think my config is the source?

from hfs.

rejetto avatar rejetto commented on July 4, 2024

What version are you using?

from hfs.

soleofthesea avatar soleofthesea commented on July 4, 2024

Latest one, 0.52.6.

from hfs.

rejetto avatar rejetto commented on July 4, 2024

Can you tell me if the problem is present with previous .5?

from hfs.

soleofthesea avatar soleofthesea commented on July 4, 2024

Problem is not present in 0.52.5.

from hfs.

rejetto avatar rejetto commented on July 4, 2024

can you send me your nginx and hfs configuration?
you can do it privately if you want [email protected]

from hfs.

soleofthesea avatar soleofthesea commented on July 4, 2024

Wait, what reason? The only changes I made, if you can call it that, is to insert the sample https://github.com/rejetto/hfs/wiki/Reverse-proxy .

from hfs.

rejetto avatar rejetto commented on July 4, 2024

how am i supposed to investigate your problem?
reverse proxy works well on my computer

from hfs.

rejetto avatar rejetto commented on July 4, 2024

wait, maybe i've found something

from hfs.

rejetto avatar rejetto commented on July 4, 2024

are you running hfs as binary (no npx) on linux?

the problem depended on the HFS' configuration, that's why it didn't show up on mine.
i have the fix and tested it myself, but I would like you to try and confirm it's good for you too.

from hfs.

soleofthesea avatar soleofthesea commented on July 4, 2024

No, I'm running via npx.

from hfs.

rejetto avatar rejetto commented on July 4, 2024

ok, by running npx hfs@exp
you will run the fixed version.
do you mind having a look at it?
just as en extra pair of eyes on it.
otherwise i will just go ahead

from hfs.

soleofthesea avatar soleofthesea commented on July 4, 2024

Still not working, unfortunately...

from hfs.

rejetto avatar rejetto commented on July 4, 2024

does your version say 0.52.7-rc1 ?

from hfs.

soleofthesea avatar soleofthesea commented on July 4, 2024

image

from hfs.

rejetto avatar rejetto commented on July 4, 2024

that's weird.
the problem i just fixed was related to using or not "roots" feature.
now i tested with both situation and works for me.
image

now i have NO clue on your problem.
you can consider sending me your conf.
and thanks for test!

from hfs.

soleofthesea avatar soleofthesea commented on July 4, 2024

Ah, I see what may be the issue - I should've specified the bug ONLY appears if you use a reverse proxy. I also have no problems if I access directly, although again I point out it worked/works fine with 0.52.5.

from hfs.

rejetto avatar rejetto commented on July 4, 2024

that was already clear, the screenshot i posted is of the reverse proxy.
last problem was of "roots" + proxy

from hfs.

rejetto avatar rejetto commented on July 4, 2024

i've been experimenting and maybe i've found how to reproduce the problem on my side

from hfs.

soleofthesea avatar soleofthesea commented on July 4, 2024

Okay, here's a copy of the .hfs and nginx folders from that VM I spun up (and verified the bug).

Terminal commands I used, for reference in case there was something I forgot to type
sudo apt install nginx
sudo apt install npx
sudo systemctl start nginx
npx hfs

If it's still not reproducable then I'm stumped.

from hfs.

rejetto avatar rejetto commented on July 4, 2024

thanks but as i said on my post, I already reproduced the problem and i'm producing the fix.
it was another thing in my hfs config

from hfs.

rejetto avatar rejetto commented on July 4, 2024

ok, i just published another hfs@exp
now it is 0.52.7-rc2
would you give me a feedback, if you can?

from hfs.

soleofthesea avatar soleofthesea commented on July 4, 2024

Well, the good news is that the main functionality of browsing files is back;

But the redirect feature is still not quite right. If you omit the leading slash it's also missing in the URL, so it's example.com/filesFiles when it should be example.com/files/Files.

from hfs.

rejetto avatar rejetto commented on July 4, 2024

i see, thanks for reporting.
i'm looking into it.

from hfs.

rejetto avatar rejetto commented on July 4, 2024

ok, i just published another hfs@exp
now it is 0.52.7-rc3
would you give me a feedback, if you can?
thanks for your patience

from hfs.

soleofthesea avatar soleofthesea commented on July 4, 2024

No, thank you for the awesome free app.
So far seems to be fine; no issues on my end.

from hfs.

rejetto avatar rejetto commented on July 4, 2024

thank you for your feedback!
published as hfs@latest

from hfs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.