Git Product home page Git Product logo

Comments (5)

tmysik avatar tmysik commented on June 5, 2024 1

I just needed to workaround this by setting set -g __fish_sdkman_init "/my/path/to/sdkman/bin/sdkman-init.sh" in ~/.config/fish/config.fish. Seems to be working fine.

Note: I have installed SDKMAN! (in my custom directory) before sdkman-for-fish and it wanted me to download and install it again.

from sdkman-for-fish.

reitzig avatar reitzig commented on June 5, 2024

You mean we should use SDKMAN_DIR instead? That makes sense to me, but I'd have to look at it more closely to not break the case where sdkman-for-fish installs sdkman.

FWIW, I think this is a new feature in SDKMAN! 5.8.x; cf. #35

from sdkman-for-fish.

reitzig avatar reitzig commented on June 5, 2024

Thanks! I figured it should be that simple, but I'll have to figure out how to handle

  • not knowing SDKMAN_DIR without running it first (critical), and
  • installing it to a custom location (nice to have).

Maybe it'll have to be an (optional) setting with HOME as the default, but I would prefer to have an automatism.

from sdkman-for-fish.

tmysik avatar tmysik commented on June 5, 2024

@reitzig Maybe it could be interactive? Now, you are checking some variable and do installation if not set. What if you asked user what to do, whether SDKMAN! was already installed, etc. if such a variable is not set?

from sdkman-for-fish.

reitzig avatar reitzig commented on June 5, 2024

It'll be like this: If globale fish variable __sdkman_custom_dir is set, we will respect its value.

That is, if you have a custom installation, add

set -g __sdkman_custom_dir /your/path

to .config/fish/conf.d/config_sdk.fish.

cf. corner_cases.feature#14

Sorry for the long wait, but it's done now! 🙃

from sdkman-for-fish.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.