sentry appender potential error about semantic_logger HOT 7 CLOSED

Needs a full stacktrace posted.

from semantic_logger.

Hey @nateberkopec @reidmorrison. Sorry, I completely forgot about this (holiday effect I guess).

I think I know where the problem is, but didn't get a chance to test it yet

If you look here, the context is being munged to fit with the raven structure (that was part of the fix I applied on #70).

What I missed however, is doing the same thing when an exception is raised just a few lines above it.

Hope to find time to test and apply this fix over the weekend hopefully.

from semantic_logger.

@reidmorrison created a PR that should fix this. Since the tests are rather synthetic, I'm wondering how to simulate this on a "real" environment though... Any pointers?

from semantic_logger.

@gingerlime check out this test for an example on how to use both mocks during tests and then to actually call the target system on demand for "real" development testing: https://github.com/rocketjob/semantic_logger/blob/master/test/metric/signalfx_test.rb#L13

It does it by means of an environment variable so that testing in Travis is mocked.

from semantic_logger.

Thanks @reidmorrison. That's a good suggestion.

I'm still curious to understand when this branch of the appender is activated though? (When does log.exception get set, or how to simulate it from the console)

from semantic_logger.

How about we do a screen sharing session and walk through the code?
I am available 10am through 5 pm Eastern (NY) time, send me a private message through Github with a time and I will send you link to chat.

from semantic_logger.

Thanks @reidmorrison, that's exceptionally kind of you. Totally awesome... I really don't want to take up your time though (and it's also pretty busy here, to be perfectly honest).

I hope to find some time to play around with it a bit more over the weekend, and hope to figure things out. Hope to keep the option for a screenshare open for future though? I'm sure something or other will come up, and I'd love the opportunity, but best to keep it for something more important.

Cheers,
Yoav

from semantic_logger.