Formatting comments about rehype-format HOT 3 CLOSED

👍

How this works is to first remove all whitespace, and then to add some back.
I don’t think there’s any real special care for of comments, but for a solution I think just handling them the same as elements would work.

Can you create a PR?

from rehype-format.

@wooorm Thanks for replying. I took a look at the code, made some obvious changes, and found myself down a rabbit hole. I'm not convinced that this is a productive direction. I switched over to using a different HTML beautifier. I also need some convincing that the current logic preserves the exact semantics of the input, in cases such as <span>foo</span><span>bar</span>, where the non-existence of white space between the two spans has particular semantics which would be broken by moving them onto separate lines. I also am not convinced that the whole approach of starting off by squashing is the right way to go; among other reasons, it prevents any logic based on some level of preservation of original formatting, which is desirable in some cases, and provided by other HTML formatters.

from rehype-format.

Well, that was a long time!

fwiw, most of the bugs with the previous approach had to do with rehypejs/rehype-minify#19, which you alluded to as well with “I also am not convinced that the whole approach of starting off by squashing is the right way to go”.

Stay safe!

from rehype-format.