Last image is still shown in FrontEnd after deletion about refinerycms-page-images HOT 7 CLOSED

I'm not sure.. are you sure you saved the page? Year old issue so maybe you fixed it already..

from refinerycms-page-images.

This does still happen.

If you have only one image on the page, trying to delete it doesn't work. The javascript removes it from the view, but saving the page does not delete the image from the page. If you edit the page again, the image is back.

from refinerycms-page-images.

Yeah just stumbled on this issue. It's not a super easy one because of the way the plugin is architectured. Since there are no inputs left, the form does not submit anything for images, therefore no images are getting deleted. We want to submit an empty array through POST, but I'm not sure you can do this with Rails / Rack. Another option would be to change the plugin and use _destroy attribute rather than fancy deleting logic, but that's basically changing the HTTP API and could be backward incompatible.

I'll look into it tomorrow, but it's most likely not going to be pretty. If anyone sees an easy fix, I'd be glad to hear.

from refinerycms-page-images.

I think that using _destroy would be the best, personally.. if that's possible.

from refinerycms-page-images.

@parndt It of course would be better. Honestly, this plugin is really hard to maintain and breaks a lot of conventions all over the place.

I tried to quickly implement a fix using _destroy, but that basically means changing pretty much all the logic in the backend, the frontend, and how the images are associated. I decided to add a little patch on the pile rather than rewriting the plugin from the ground up. Sorry about that.

from refinerycms-page-images.

@jbourassa seems like it works though, care to open a pull request?

from refinerycms-page-images.

The first one is a mistake =( I tried something but it didn't quite turn out as I expected.

from refinerycms-page-images.