Git Product home page Git Product logo

Comments (6)

JackKCWong avatar JackKCWong commented on June 3, 2024 1

Wonderful news! It's been a long time and I've switched to a Mac :)
I am still interested in testing it though, just have to find a Windows kit, maybe in 1 or 2 weeks.

from readline.

maxlandon avatar maxlandon commented on June 3, 2024

Hello ! Sorry I've been completely off for a few months, and I resumed work on this library only a few weeks ago.

The library has been almost entirely rewritten, with a new model, cleaner code base, and many new features and enhancements. If you are still using it, or considering, could you try the new version and tell me if the problem persists ?
Thanks a lot.

from readline.

maxlandon avatar maxlandon commented on June 3, 2024

Hello @JackKCWong
Did you give this a try ?
Normally the latest release should have fixed cursor offset computations, but I would greatly appreciate a feedback for Windows !

from readline.

JackKCWong avatar JackKCWong commented on June 3, 2024

hey, sry I haven't found any snippet to run a quick test on it and haven't got the time to dive into the docs.
I did try the console/example mentioned in the readme but it's pretty off. Not sure if you intend to support Windows or now.
I will have another go next week.
IMG_20230210_124130_edit_67006356603317

from readline.

maxlandon avatar maxlandon commented on June 3, 2024

I have not personally tested for Windows.
Note that the example console uses a default Oh-my-posh prompt engine/configuration, and oh-my-posh is supposed to be working great on Windows.
So I'll try my example on a Windows machine, and will reach back to you once done, with things fixed on my side.

from readline.

maxlandon avatar maxlandon commented on June 3, 2024

Coming back to this issue:

  • Cursor offset: this should be solved since the library has undergone major rewrites, in which cursor computation/display logic has been drastically improved.
  • Prompt rendering: I think the prompt above is from the reeflective/console example binary. I suspect that this is due
    to me having forgot to adjust the default oh-my-posh engine settings (the shell type should powershell). I will fix this in the mentionned repo.

Closing this issue for now. Don't hesitate reopening or creating new ones if you encounter other problems.

from readline.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.